[Bug analyzer/104680] identical inner condition not detected

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104680

--- Comment #7 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
> trunk.git/zlib/contrib/minizip/zip.c:1212:26: warning: Identical inner 'if' condition is always true. [identicalInnerCondition]

In zipOpenNewFileInZip4_64:

1206   │ #ifdef HAVE_BZIP2
1207   │     if ((err==ZIP_OK) && (zi->ci.method == Z_DEFLATED || zi->ci.method
== Z_BZIP2ED) && (!zi->ci.raw))
1208   │ #else
1209   │     if ((err==ZIP_OK) && (zi->ci.method == Z_DEFLATED) &&
(!zi->ci.raw))
1210   │ #endif
1211   │     {
1212   │         if(zi->ci.method == Z_DEFLATED)
1213   │         {

Arguably a false positive: it's going to be a repeated test if the preprocessor
uses line 1209, but not if it uses line 1207.