[Bug modula2/108153] Profiled lto bootstrap failure with modula2

cvs-commit at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Wed Dec 21 08:18:19 GMT 2022


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108153

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:88709c4a1e6f8b69a33897a1ab46b8d66c4569c4

commit r13-4824-g88709c4a1e6f8b69a33897a1ab46b8d66c4569c4
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Dec 21 09:10:35 2022 +0100

    modula2: Fix lto profiledbootstrap on powerpc64le-linux and s390x-linux
[PR108153]

    Lto profiledbootstrap was failing for me on {powerpc64le,s390x}-linux with
    modula 2 enabled, with:
    cc1gm2: internal compiler error: the location value is corrupt
    0x11a3d2d m2assert_AssertLocation(unsigned int)
            ../../gcc/m2/gm2-gcc/m2assert.cc:40
    0x11a3d2d m2statement_BuildAssignmentTree
            ../../gcc/m2/gm2-gcc/m2statement.cc:177
    ICE.  The problem was that caller (m2assert_AssertLocation used
    location_t M2Options_OverrideLocation (location_t);
    prototype with the libcpp/line-map.h
    typedef unsigned int location_t;
    typedef, but the callee defined in Modula 2 was using:
    TYPE
       location_t = INTEGER ;
    and
    PROCEDURE OverrideLocation (location: location_t) : location_t ;
    Now, on powerpc64le-linux unsigned int is returned and passed zero extended
    into 64-bits, while signed int is returned and passed sign-extended into
64-bits
    and Modula 2 INTEGER is signed 32-bit type, so when the caller then
compared
    M2Options_OverrideLocation (location) != location
    and powerpc64le-linux performed the comparison as 64-bit compare, there
    was a mismatch for location_t of 0x8000007 or others with the MSB set.

    Fixed by making Modula 2 location_t a CARDINAL, which is 32-bit unsigned
type.

    2022-12-21  Jakub Jelinek  <jakub@redhat.com>

            PR modula2/108153
            * gm2-gcc/m2linemap.def (location_t): Use CARDINAL instead of
INTEGER.


More information about the Gcc-bugs mailing list