[Bug debug/105089] CTF for a defined extern variable is ambiguous

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105089

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Indu Bhagat <ibhagat@gcc.gnu.org>:

https://gcc.gnu.org/g:d634c5d7c78c6ec0fa39d96984460475564519c8

commit r12-8164-gd634c5d7c78c6ec0fa39d96984460475564519c8
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date:   Thu Apr 14 10:02:45 2022 -0700

    Refactor and update CTF testcases [PR105089]

    This commit splits the ctf-array-2.c into ctf-array-5.c and
    ctf-variables.c with the following responsibilities:

    [1] ctf-array-2.c: Test CTF generation for unsized arrays.
    [2] ctf-array-5.c: Test CTF generation for unsized but initialized array.
    [3] ctf-variables-3.c: Test CTF generation for extern variable with
defining
    decl.

    Earlier all three tests above were being done in ctf-array-2.c.  The
    checks around [3] were very loose in the original version of ctf-array-2.c
    in that the testcase was only checking that the types are as expected.  The
    compiler was emitting two CTF variable records as follows:

     Variables:
      _CTF_NEWSTR ->  5: const const char [0] (size 0x0) -> 4: const char [0]
(size 0x0)
      _CTF_NEWSTR ->  8: const const char [8] (size 0x8) -> 7: const char [8]
(size 0x8)

    This is incorrect behaviour as it creates ambiguity.  The testcase
    ctf-variables-3.c now has added checks that only one CTF variable record
    is expected.

    2022-04-14  Indu Bhagat  <indu.bhagat@oracle.com>

    gcc/testsuite/ChangeLog:

            PR debug/105089
            * gcc.dg/debug/ctf/ctf-array-2.c: Refactor testcase.  Move some
            checks ...
            * gcc.dg/debug/ctf/ctf-array-5.c: ... to here.
            * gcc.dg/debug/ctf/ctf-variables-3.c: ... and here.  Add
            additional checks for one CTF variable and one CTF object info
            record.