[Bug ipa/103451] [12 Regression] crash at gcc/range-op.cc:1836 since r12-5531-g1b0acc4b800b589a

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103451

--- Comment #4 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #2)
> So range-op.cc eventually wants to look at 'cfun' which of course is a
> non-go in IPA context.
> 
> void
> operator_div::wi_fold (irange &r, tree type,
>                        const wide_int &lh_lb, const wide_int &lh_ub,
>                        const wide_int &rh_lb, const wide_int &rh_ub) const
> {
> ...
>   // If flag_non_call_exceptions, we must not eliminate a division by zero.
>   if (cfun->can_throw_non_call_exceptions)
>     {
>       r.set_varying (type);
>       return;
> 
> I'm not sure wi_fold should care about "eliminating a division", but surely
> even for non-call EH the actual range of the result doesn't need to care.
> 
> So if sth goes wrong when eliding the above it needs to be fixed upthread
> instead?
> 
> Otherwise a "quick" workaround for the ICE is to check !cfun || ... and
> be conservative.  I see there's no state associated with
> range_fold_binary_expr
> where the IPA context could pass down relevant can_throw_non_call_exceptions.

I honestly can't remember what the rationale was for checking
can_throw_non_call_exceptions.  Perhaps this got added to catch some testcase? 
My gut feeling is that we should be fixing whatever issue upstream, but !cfun
|| ... seems quite harmless.

> 
> I also see
> 
> bool
> fold_using_range::range_of_builtin_call (irange &r, gcall *call,
>                                          fur_source &src)
> ...
>       if (cfun->after_inlining)
>         {
>           r.set_zero (type);
> 
> which might have similar problems (!cfun || ... looks quite reasonable there)

This one came from the old vr-values.c code, so you may have better insight
here ;-)

commit 46dfa8ad6c18feb45d35734eae38798edb7c38cd
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Sep 11 11:16:54 2019 +0000

    re PR tree-optimization/90387 (__builtin_constant_p and -Warray-bounds
warnings)

    2019-09-11  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/90387
            * vr-values.c (vr_values::extract_range_basic): After inlining
            simplify non-constant __builtin_constant_p to false.

            * gcc.dg/Warray-bounds-44.c: New testcase.

    From-SVN: r275639