[Bug target/100333] arm: ICE (unrecognizable insn) with CMSE nonsecure call and -march=armv8.1-m.main

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100333

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Alex Coplan
<acoplan@gcc.gnu.org>:

https://gcc.gnu.org/g:fe28b9da8f81c678bf5807eba413fae09ac36e72

commit r10-9889-gfe28b9da8f81c678bf5807eba413fae09ac36e72
Author: Alex Coplan <alex.coplan@arm.com>
Date:   Wed May 19 15:52:45 2021 +0100

    arm: Fix ICE with CMSE nonsecure calls on Armv8.1-M [PR100333]

    As the PR shows, we ICE shortly after expanding nonsecure calls for
Armv8.1-M.
    For Armv8.1-M, we have TARGET_HAVE_FPCXT_CMSE. As it stands, the expander
    (arm.md:nonsecure_call_internal) moves the callee's address to a register
(with
    copy_to_suggested_reg) only if !TARGET_HAVE_FPCXT_CMSE.

    However, looking at the pattern which the insn appears to be intended to
    match (thumb2.md:*nonsecure_call_reg_thumb2_fpcxt), it requires the
    callee's address to be in a register.

    This patch therefore just forces the callee's address into a register in
    the expander.

    gcc/ChangeLog:

            PR target/100333
            * config/arm/arm.md (nonsecure_call_internal): Always ensure
            callee's address is in a register.

    gcc/testsuite/ChangeLog:

            PR target/100333
            * gcc.target/arm/cmse/pr100333.c: New test.

    (cherry picked from commit 5b953740da1976d90d974055c6d825c509c6e654)