[Bug c++/95451] [8/9 regression] ICE for lambda capturing this and calling operator() since r8-2720-gf44a8dd56f5bfbd0

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95451

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:1f7f4e1118ab7f1118a2977303b672ecec439a6b

commit r9-9427-g1f7f4e1118ab7f1118a2977303b672ecec439a6b
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Feb 26 10:43:28 2021 +0100

    c++: Fix operator() lookup in lambdas [PR95451]

    During name lookup, name-lookup.c uses:
                if (!(!iter->type && HIDDEN_TYPE_BINDING_P (iter))
                    && (bool (want & LOOK_want::HIDDEN_LAMBDA)
                        || !is_lambda_ignored_entity (iter->value))
                    && qualify_lookup (iter->value, want))
                  binding = iter->value;
    Unfortunately as the following testcase shows, this doesn't work in
    generic lambdas, where we on the auto b = ... lambda ICE and on the
    auto d = lambda reject it even when it should be valid.  The problem
    is that the binding doesn't have a FUNCTION_DECL with
    LAMBDA_FUNCTION_P for the operator(), but an OVERLOAD with
    TEMPLATE_DECL for such FUNCTION_DECL.

    The following patch fixes that in is_lambda_ignored_entity, other
    possibility would be to do that before calling is_lambda_ignored_entity
    in name-lookup.c.

    2021-02-26  Jakub Jelinek  <jakub@redhat.com>

            PR c++/95451
            * lambda.c (is_lambda_ignored_entity): Before checking for
            LAMBDA_FUNCTION_P, use OVL_FIRST.  Drop FUNCTION_DECL check.

            * g++.dg/cpp1y/lambda-generic-95451.C: New test.

    (cherry picked from commit 8f9308936cf1df134d5aac1f890eb67266530ab5)