[Bug analyzer/94433] enhancement: 12 * constify some parameters

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94433

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Thanks for filing this.  I've been attempting to reproduce this, but I'm not
getting any warnings out of cppcheck.

That said, looking at
  git show
a96f1c38a787fbc847cb014d4b094e2787d539a7:gcc/analyzer/diagnostic-manager.cc
(to get the version for the bug was filed) the first few warnings in comment #0
seem to be on class dedupe_hash_map_traits:

 289   │   static inline hashval_t hash (const key_type &v)
 291   │   {
 292   │     return v->hash ();
 293   │   }
 294   │   static inline bool equal_keys (const key_type &k1, const key_type
&k2)
 295   │   {
 296   │     return *k1 == *k2;
 297   │   }

where key_type is:
 286   │   typedef const dedupe_key *key_type;

and I don't think the above code has changed since then.

Is there a good way to invoke cppcheck on GCC?  I'm naively trying "cppcheck
gcc/analyzer" and passing in -I options, and am not getting any warnings.