[Bug middle-end/96459] OpenMP host teams reductions ignored

cvs-commit at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Wed Sep 16 19:22:48 GMT 2020


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96459

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:464ed899038051f80af1df7197e561f327502107

commit r9-8906-g464ed899038051f80af1df7197e561f327502107
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Aug 5 10:40:10 2020 +0200

    openmp: Handle reduction clauses on host teams construct [PR96459]

    As the new testcase shows, we weren't actually performing reductions on
    host teams construct.  And fixing that revealed a flaw in the for-14.c
testcase.
    The problem is that the tests perform also initialization and checking
around the
    calls to the functions with the OpenMP constructs.  In that testcase, all
the
    tests have been spawned from a teams construct but only the tested loops
were
    distribute, which means the initialization and checking has been performed
    redundantly and racily in each team.  Fixed by performing the
initialization
    and checking outside of host teams and only do the calls to functions with
    the tested constructs inside of host teams.

    2020-08-05  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/96459
            * omp-low.c (lower_omp_taskreg): Call lower_reduction_clauses even
in
            for host teams.

            * testsuite/libgomp.c/teams-3.c: New test.
            * testsuite/libgomp.c-c++-common/for-2.h (OMPTEAMS): Define to
nothing
            if not defined yet.
            (N(test)): Use it before all N(f*) calls.
            * testsuite/libgomp.c-c++-common/for-14.c (DO_PRAGMA, OMPTEAMS):
Define.
            (main): Don't call all test_* functions from within
            #pragma omp teams reduction(|:err), call them directly.

    (cherry picked from commit 916c7a201a9a1dc94f2c056a773826a26d1daca9)


More information about the Gcc-bugs mailing list