[Bug preprocessor/95013] [11 Regression] FAIL: obj-c++.dg/property/property-neg-6.mm syntax-error-10.mm

cvs-commit at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Tue May 12 20:40:40 GMT 2020


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95013

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathan Sidwell <nathan@gcc.gnu.org>:

https://gcc.gnu.org/g:2a0225e47868fbfceaecaa5e2de96c1c5a2251ea

commit r11-338-g2a0225e47868fbfceaecaa5e2de96c1c5a2251ea
Author: Nathan Sidwell <nathan@acm.org>
Date:   Tue May 12 13:33:11 2020 -0700

    preprocessor: EOF location is at end of file [PR95013]

    My recent C++ parser change to pay attention to EOF location uncovered
    a separate bug.  The preprocesor's EOF logic would set the EOF
    location to be the beginning of the last line of text in the file --
    not the 'line' after that, which contains no characters.  Mostly.
    This fixes things so that when we attempt to read the last line of the
    main file, we don't pop the buffer until the tokenizer has a chance to
    create an EOF token with the correct location information.  It is then
    responsible for popping the buffer.  As it happens, raw string literal
    tokenizing contained a bug -- it would increment the line number
    prematurely, because it cached buffer->cur in a local variable, but
    checked buffer->cur before updating it to figure out if it was at end
    of file.   We fix up that too.

    The EOF token intentionally doesn't have a column number -- it's not a
    position on a line, it's a non-existant line.

    The testsuite churn is just correcting the EOF location diagnostics.

            libcpp/
            PR preprocessor/95013
            * lex.c (lex_raw_string): Process line notes before incrementing.
            Correct incrementing condition.  Adjust for new
            _cpp_get_fresh_line EOF behaviour.
            (_cpp_get_fresh_line): Do not pop buffer at EOF, increment line
            instead.
            (_cpp_lex_direct): Adjust for new _cpp_get_fresh_line behaviour.
            (cpp_directive_only_process): Assert we got a fresh line.
            * traditional.c (_cpp_read_logical_line_trad): Adjust for new
            _cpp_get_fresh_line behaviour.

            gcc/testsuite/
            * c-c++-common/goacc/pr79428-1.c: Adjust EOF diagnostic location.
            * c-c++-common/gomp/pr79428-2.c: Likewise.
            * g++.dg/cpp0x/decltype63.C: Likewise.
            * g++.dg/cpp0x/gen-attrs-64.C: Likewise.
            * g++.dg/cpp0x/pr68726.C: Likewise.
            * g++.dg/cpp0x/pr78341.C: Likewise.
            * g++.dg/cpp1y/pr65202.C: Likewise.
            * g++.dg/cpp1y/pr65340.C: Likewise.
            * g++.dg/cpp1y/pr68578.C: Likewise.
            * g++.dg/cpp1z/class-deduction44.C: Likewise.
            * g++.dg/diagnostic/unclosed-extern-c.C: Likewise.
            * g++.dg/diagnostic/unclosed-function.C: Likewise.
            * g++.dg/diagnostic/unclosed-namespace.C: Likewise.
            * g++.dg/diagnostic/unclosed-struct.C: Likewise.
            * g++.dg/ext/pr84598.C: Likewise.
            * g++.dg/other/switch4.C: Likewise.
            * g++.dg/parse/attr4.C: Likewise.
            * g++.dg/parse/cond4.C: Likewise.
            * g++.dg/parse/crash10.C: Likewise.
            * g++.dg/parse/crash18.C: Likewise.
            * g++.dg/parse/crash27.C: Likewise.
            * g++.dg/parse/crash34.C: Likewise.
            * g++.dg/parse/crash35.C: Likewise.
            * g++.dg/parse/crash52.C: Likewise.
            * g++.dg/parse/crash59.C: Likewise.
            * g++.dg/parse/crash61.C: Likewise.
            * g++.dg/parse/crash67.C: Likewise.
            * g++.dg/parse/error14.C: Likewise.
            * g++.dg/parse/error56.C: Likewise.
            * g++.dg/parse/invalid1.C: Likewise.
            * g++.dg/parse/parameter-declaration-1.C: Likewise.
            * g++.dg/parse/parser-pr28152-2.C: Likewise.
            * g++.dg/parse/parser-pr28152.C: Likewise.
            * g++.dg/parse/pr68722.C: Likewise.
            * g++.dg/pr46852.C: Likewise.
            * g++.dg/pr46868.C: Likewise.
            * g++.dg/template/crash115.C: Likewise.
            * g++.dg/template/crash43.C: Likewise.
            * g++.dg/template/crash90.C: Likewise.
            * g++.dg/template/error-recovery1.C: Likewise.
            * g++.dg/template/error57.C: Likewise.
            * g++.old-deja/g++.other/crash31.C: Likewise.
            * gcc.dg/empty-source-2.c: Likewise.
            * gcc.dg/empty-source-3.c: Likewise.
            * gcc.dg/noncompile/pr30552-3.c: Likewise.
            * gcc.dg/noncompile/pr35447-1.c: Likewise.
            * gcc.dg/pr20245-1.c: Likewise.
            * gcc.dg/pr28419.c: Likewise.
            * gcc.dg/rtl/truncated-rtl-file.c: Likewise.
            * gcc.dg/unclosed-init.c: Likewise.
            * obj-c++.dg/property/property-neg-6.mm: Likewise.
            * obj-c++.dg/syntax-error-10.mm: Likewise.
            * obj-c++.dg/syntax-error-8.mm: Likewise.
            * obj-c++.dg/syntax-error-9.mm: Likewise.


More information about the Gcc-bugs mailing list