[Bug bootstrap/95582] [11 Regression] LTO lean + PGO bootstrap is broken in Ada

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95582

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu.org

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
I can reproduce it, yes.

_22 = (boolean) _21;

converts

 <ssa_name 0x7ffff62e3000
    type <boolean_type 0x7ffff6821b28 bool public unsigned QI
        size <integer_cst 0x7ffff680cca8 constant 8>
        unit-size <integer_cst 0x7ffff680ccc0 constant 1>
        align:8 warn_if_not_align:0 symtab:0 alias-set -1 canonical-type
0x7ffff6821b28 precision:1 min <integer_cst 0x7ffff680cf00 0> max <integer_cst
0x7ffff680cf30 1>>
    visited
    def_stmt _21 = _11 != _12;
    version:21>

to

 <ssa_name 0x7ffff62e3048
    type <boolean_type 0x7ffff66133f0 boolean public unsigned QI
        size <integer_cst 0x7ffff680cca8 constant 8>
        unit-size <integer_cst 0x7ffff680ccc0 constant 1>
        align:8 warn_if_not_align:0 symtab:0 alias-set 23 canonical-type
0x7ffff66133f0 precision:8 min <integer_cst 0x7ffff6a057b0 0> max <integer_cst
0x7ffff6a05798 255> context <translation_unit_decl 0x7ffff68161e0
ada/b_gnatb.adb>
        pointer_to_this <pointer_type 0x7ffff66b2000>>
    visited
    def_stmt _22 = (boolean) _21;
    version:22
    ptr-info 0x7ffff6303cc0>

so Ada has BOOLEAN_TYPE with 8-bit precision and the middle-end
boolean_type_node is the one with 1-bit precision.

the origs stmt mask_precision is 16 coming from the _11 != _12 compare
with HImode operands.

A C or even GIMPLE testcase is difficult because we have no way to
declare that 8-bit BOOLEAN_TYPE.  But a fix for the ICE is likely
just to enhance VECT_SCALAR_BOOLEAN_TYPE.

We do have other tests like this in forwprop for example:

  /* Canonicalize _Bool == 0 and _Bool != 1 to _Bool != 0 by swapping edges. 
*/
  if ((TREE_CODE (TREE_TYPE (rhs1)) == BOOLEAN_TYPE
       || (INTEGRAL_TYPE_P (TREE_TYPE (rhs1))
           && TYPE_PRECISION (TREE_TYPE (rhs1)) == 1))

so we generally seem to assume BOOLEAN_TYPE has 1 bit precision?  CCing
Eric, eventually the bootstrap issue icks on a corner case of the Ada
FE and is a bug there.

The following would fix it in the vectorizer:

diff --git a/gcc/tree-vectorizer.h b/gcc/tree-vectorizer.h
index 9bb82a546f6..8c8ec6cb111 100644
--- a/gcc/tree-vectorizer.h
+++ b/gcc/tree-vectorizer.h
@@ -1254,11 +1254,11 @@ struct gather_scatter_info {
    VECTOR_BOOLEAN_TYPE_P.  */

 #define VECT_SCALAR_BOOLEAN_TYPE_P(TYPE) \
-  (TREE_CODE (TYPE) == BOOLEAN_TYPE            \
-   || ((TREE_CODE (TYPE) == INTEGER_TYPE       \
-       || TREE_CODE (TYPE) == ENUMERAL_TYPE)   \
-       && TYPE_PRECISION (TYPE) == 1           \
-       && TYPE_UNSIGNED (TYPE)))
+  ((TREE_CODE (TYPE) == BOOLEAN_TYPE    \
+    || TREE_CODE (TYPE) == INTEGER_TYPE         \
+    || TREE_CODE (TYPE) == ENUMERAL_TYPE)\
+    && TYPE_PRECISION (TYPE) == 1       \
+    && TYPE_UNSIGNED (TYPE))

 static inline bool
 nested_in_vect_loop_p (class loop *loop, stmt_vec_info stmt_info)


Maybe Eric can also create something for gnat.dg?  What it needs is
an appearant opportunity in the basic-block thus the two adjacent
stores plus the compare and convert.  Eventually the dump of the
function Martin provided is enough to produce a testcase that ICEs?