[Bug middle-end/96335] [10/11 Regression] ICE in maybe_warn_rdwr_sizes since r10-4929

cvs-commit at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Tue Jul 28 09:09:19 GMT 2020


--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:


commit r11-2379-gf9264b9008386ac3b5c795472c222fa524b127b0
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Jul 28 11:08:29 2020 +0200

    expander: Fix ICE in maybe_warn_rdwr_sizes [PR96335]

    The following testcase ICEs in maybe_warn_rdwr_sizes.  The problem is that
    the caller uses its fndecl and fntype variables to fill up rdwr_map, and
    the fntype in that case is a prototype with the access attribute and all
    the checks needed for that performed.  But the maybe_warn_rdwr_sizes
    function tries to rediscover fndecl/fntype itself and does it differently
    from how the caller did (for fndecl get_callee_fndecl and fntype from that
    FUNCTION_DECL, otherwise sets fntype to CALL_EXPR_FN's type).

    On the testcase, get_callee_fndecl does find a FUNCTION_DECL because
    it does STRIP_NOPS in between.

    Instead of trying to rediscover those, this patch just passes them down,
    like is done in several other functions.

    2020-07-28  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/96335
            * calls.c (maybe_warn_rdwr_sizes): Add FNDECL and FNTYPE arguments,
            instead of trying to rediscover them in the body.
            (initialize_argument_information): Adjust caller.

            * gcc.dg/pr96335.c: New test.

More information about the Gcc-bugs mailing list