[Bug c/93949] [8/9/10 Regression] Register const local var will not compile since r0-58166

cvs-commit at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Thu Feb 27 10:27:00 GMT 2020


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93949

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b51057817d9a1aee4f24372f8c97f81f372c0a21

commit r9-8300-gb51057817d9a1aee4f24372f8c97f81f372c0a21
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Feb 27 10:45:30 2020 +0100

    gimplify: Don't optimize register const vars to static [PR93949]

    The following testcase is rejected, while it was accepted in 3.4 and
earlier
    (before tree-ssa merge).
    The problem is that we decide to promote the const variable to TREE_STATIC,
    but TREE_STATIC DECL_REGISTER VAR_DECLs may only be the global register
vars
    and so assemble_variable/make_decl_rtl diagnoses it.

    Either we do what the following patch does, where we could consider
    register as a hint the user doesn't want such optimization, because if
    something is forced static, it is not "register" anymore and register
static
    is not valid in C either, or we could clear DECL_REGISTER instead, but
would
    still need to punt at least on DECL_HARD_REGISTER cases.

    2020-02-27  Jakub Jelinek  <jakub@redhat.com>

        PR c/93949
        * gimplify.c (gimplify_init_constructor): Don't promote readonly
        DECL_REGISTER variables to TREE_STATIC.

        * gcc.c-torture/compile/pr93949.c: New test.


More information about the Gcc-bugs mailing list