[Bug c/93859] missing test for diagnostic: the omitted middle operand will always be true

roland.illig at gmx dot de gcc-bugzilla@gcc.gnu.org
Mon Feb 24 19:55:00 GMT 2020


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93859

--- Comment #2 from Roland Illig <roland.illig at gmx dot de> ---
(In reply to Jakub Jelinek from comment #1)
> git blame for the change which added the diagnostics and git log for that
> change should usually help to identify the test.

My strategy was simpler than "git blame". It was: "take the longest chain of
literal words from the diagnostic, and search for them". To me, my strategy
felt less time-consuming, therefore I didn't even think about using "git
blame".

In my opinion this simple strategy should work as well. It also means the tests
get more expressive since the dg-warning comments are self-describing.

As I already said in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93857#c4, the
words "omitted middle operand" appear in more than once diagnostic, which makes
it unnecessarily difficult to relate the tests to the diagnostic.


More information about the Gcc-bugs mailing list