[Bug fortran/90093] Extended C interop: optional argument incorrectly identified as PRESENT

[pault at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90093

--- Comment #3 from Paul Thomas <pault at gcc dot gnu.org> ---
Author: pault
Date: Fri May 10 07:59:42 2019
New Revision: 271057

URL: https://gcc.gnu.org/viewcvs?rev=271057&root=gcc&view=rev
Log:
2019-05-10  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/90093
        * trans-decl.c (convert_CFI_desc): Test that the dummy is
        present before doing any of the conversions.

        PR fortran/90352
        * decl.c (gfc_verify_c_interop_param): Restore the error for
        charlen > 1 actual arguments passed to bind(C) procs.
        Clean up trailing white space.

        PR fortran/90355
        * trans-array.c (gfc_trans_create_temp_array): Set the 'span'
        field to the element length for all types.
        (gfc_conv_expr_descriptor): The force_no_tmp flag is used to
        prevent temporary creation, especially for substrings.
        * trans-decl.c (gfc_trans_deferred_vars): Rather than assert
        that the backend decl for the string length is non-null, use it
        as a condition before calling gfc_trans_vla_type_sizes.
        * trans-expr.c (gfc_conv_gfc_desc_to_cfi_desc): 'force_no_tmp'
        is set before calling gfc_conv_expr_descriptor.
        * trans.c (get_array_span): Move the code for extracting 'span'
        from gfc_build_array_ref to this function. This is specific to
        descriptors that are component and indirect references.
        * trans.h : Add the force_no_tmp flag bitfield to gfc_se.

2019-05-10  Paul Thomas  <pault@gcc.gnu.org>

        PR fortran/90093
        * gfortran.dg/ISO_Fortran_binding_12.f90: New test.
        * gfortran.dg/ISO_Fortran_binding_12.c: Supplementary code.

        PR fortran/90352
        * gfortran.dg/iso_c_binding_char_1.f90: New test.

        PR fortran/90355
        * gfortran.dg/ISO_Fortran_binding_4.f90: Add 'substr' to test
        the direct passing of substrings as descriptors to bind(C).
        * gfortran.dg/assign_10.f90: Increase the tree_dump count of
        'atmp' to account for the setting of the 'span' field.
        * gfortran.dg/transpose_optimization_2.f90: Ditto.

Added:
    trunk/gcc/testsuite/gfortran.dg/ISO_Fortran_binding_12.c
    trunk/gcc/testsuite/gfortran.dg/ISO_Fortran_binding_12.f90
    trunk/gcc/testsuite/gfortran.dg/iso_c_binding_char_1.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/decl.c
    trunk/gcc/fortran/trans-array.c
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/fortran/trans-expr.c
    trunk/gcc/fortran/trans.c
    trunk/gcc/fortran/trans.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gfortran.dg/ISO_Fortran_binding_4.f90
    trunk/gcc/testsuite/gfortran.dg/assign_10.f90
    trunk/gcc/testsuite/gfortran.dg/transpose_optimization_2.f90