[Bug debug/88723] [9 regression] PR debug/88635 patch breaks testsuite_shared.cc compilation

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88723

--- Comment #8 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
> I don't have access to Solaris, can you attach preprocessed testsuite_shared.cc
> + the g++ options used to compile it?

Just in case, there are Solaris/SPARC systems in the compile farm now:
gcc210 running Solaris 10 and gcc211 running Solaris 11.

> The note generally shouldn't break stuff, it isn't an error, just a debugging
> hint (goes away for --enable-checking=release builds) that maybe the sparc
> delegitimize hook needs more work.

I've done some digging on that front:

* While libstdc++-dg-prune does prune notes, it is only used from
  dg-test and friends.

* However, the libstdc++ testsuite support code is compiled with
  v3_target_compile, ultimately calling DejaGnu's target.exp
  (default_target_compile).  That does some pruning itself using
  prune_warnings, but that mostly applies to linker warnings.

* The libstdc++ testsuite support code is compiled with -w to suppress
  warnings, but there's no equivalent way to suppress notes:
  diagnostic_inhibit_notes is only called from toplev.c
  (process_options) for -fcompare-debug.  Maybe that's something to be
  changed?