[Bug rtl-optimization/89490] [9 Regression] char array constant put in string merge section

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89490

--- Comment #25 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to rsandifo@gcc.gnu.org from comment #24)
> I think we should also remove the test in default_use_anchors_for_symbol_p,
> since:
> 
>   sect = SYMBOL_REF_BLOCK (symbol)->sect;
> 
> will surely fault if the block is null.  Agree the patch looks good
> with those changes.

Or add gcc_checking_assert in there as well (again with a comment that
get_block_for_section should have not created the block for those sections).

> The idea was that the block infrastructure could also be used
> at some future time to organise decls into a specific order,
> e.g. to promote locality.  Obviously that hasn't happened yet,
> but I think we should keep the SECTION_SMALL stuff as-is and
> only exclude decls that can't be put into blocks for correctness
> reasons.

Ack.