[Bug sanitizer/81715] asan-stack=1 redzone allocation is too inflexible

marxin at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Tue Sep 25 09:08:00 GMT 2018


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81715

--- Comment #29 from Martin Liška <marxin at gcc dot gnu.org> ---
I'm got a patch candidate for which I did testing of allmodconfig
configuration.
Sorting all violations against 2KB of stack memory:

Before:
TOTAL warnings: 185
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:5653:1:     23624
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:4518:1:     14144
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3882:1:     11504
                                                     
lib/atomic64_test.c:250:1:     11192
                                                     
lib/atomic64_test.c:148:1:     10352
                           
drivers/net/wireless/ralink/rt2x00/rt73usb.c:1294:1:      8680
                         
drivers/net/wireless/ralink/rt2x00/rt2500pci.c:1047:1:      7712
                          
drivers/net/wireless/ralink/rt2x00/rt2500usb.c:891:1:      7592
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:2717:1:      7472
                                  
drivers/media/dvb-frontends/stv090x.c:3431:1:      6808
                                                            
mm/vmscan.c:1497:1:      6688
                                                      
fs/fscache/stats.c:286:1:      6536
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:8659:1:      6456
                                  
drivers/media/dvb-frontends/stv090x.c:3090:1:      5880
                                                     
lib/test_overflow.c:483:1:      5856
                           
drivers/net/wireless/ralink/rt2x00/rt61pci.c:1647:1:      5792
                                  
drivers/media/dvb-frontends/stv090x.c:1595:1:      5304
                                          
drivers/scsi/fnic/fnic_trace.c:451:1:      5008
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:2420:1:      4912
                                  
drivers/media/dvb-frontends/stv090x.c:4265:1:      4840
                                                 
net/wireless/nl80211.c:2102:1:      4656
                           
drivers/net/wireless/ralink/rt2x00/rt61pci.c:2631:1:      4416
                
drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8225se.c:431:1:      4376
                                           
drivers/scsi/lpfc/lpfc_attr.c:510:1:      4272
                                                  
fs/btrfs/relocation.c:1149:1:      4224
                    
drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c:3545:1:      4216
                                               
drivers/acpi/nfit/core.c:3213:1:      4176
                          
drivers/net/wireless/ralink/rt2x00/rt2400pci.c:909:1:      4128
                           
drivers/net/wireless/ralink/rt2x00/rt61pci.c:1963:1:      4032
                           
drivers/net/wireless/ralink/rt2x00/rt73usb.c:1853:1:      4000
                           
drivers/net/wireless/ralink/rt2x00/rt61pci.c:2497:1:      3968
                                                       
fs/jbd2/commit.c:1129:1:      3920
                                        
drivers/scsi/lpfc/lpfc_debugfs.c:978:1:      3896
                                                       
fs/ocfs2/super.c:1234:1:      3856
                                
drivers/media/dvb-frontends/cxd2841er.c:3302:1:      3816
                                  
drivers/media/dvb-frontends/stv0910.c:1547:1:      3808
                                  
drivers/media/dvb-frontends/stv0367.c:2607:1:      3744
                                                     
net/core/ethtool.c:2872:1:      3584
                           
drivers/net/wireless/ralink/rt2x00/rt73usb.c:1962:1:      3472
                                                      
kernel/rcu/tree.c:2239:1:      3448
          
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:16563:1:      3424
                                                       
fs/ocfs2/namei.c:1691:1:      3400
                           
drivers/net/wireless/ralink/rt2x00/rt73usb.c:1527:1:      3392
                                                        
mm/khugepaged.c:1565:1:      3296
                                  
drivers/media/dvb-frontends/stv090x.c:1952:1:      3272
                        
drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c:2924:1:      3208
                                                          
kernel/fork.c:2104:1:      3192
          
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:16905:1:      3160
                                
drivers/media/dvb-frontends/cxd2841er.c:3501:1:      3152
                                        
drivers/scsi/snic/snic_debugfs.c:355:1:      3064
                                                        
fs/ocfs2/aops.c:1906:1:      3032
                                  
drivers/media/dvb-frontends/stv090x.c:1854:1:      3008
                         
drivers/net/wireless/ralink/rt2x00/rt2400pci.c:1171:1:      2992
                          
drivers/net/wireless/ralink/rt2x00/rt2400pci.c:399:1:      2984
                          
drivers/net/wireless/ralink/rt2x00/rt2500pci.c:405:1:      2984
                         
drivers/net/wireless/ralink/rt2x00/rt2500usb.c:1434:1:      2976
                                          
arch/x86/kernel/cpu/mshyperv.c:307:1:      2960
                                                 
net/sched/cls_flower.c:1286:1:      2936
                                          
drivers/isdn/hardware/avm/b1.c:637:1:      2936
                                                      
fs/f2fs/segment.c:4182:1:      2912
                                   
drivers/scsi/mpt3sas/mpt3sas_scsih.c:9467:1:      2904
                                                  
net/rxrpc/call_event.c:459:1:      2896
                               
drivers/rapidio/devices/rio_mport_cdev.c:2129:1:      2872
                           
drivers/net/wireless/ralink/rt2x00/rt61pci.c:1503:1:      2848
                                                         
fs/nfs/write.c:1357:1:      2840
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3999:1:      2840
                                                          
fs/nfs/pnfs.c:2023:1:      2832
                                                       
net/caif/cfctrl.c:549:1:      2824
                                          
drivers/block/drbd/drbd_req.c:1447:1:      2800
                                                               
mm/gup.c:1757:1:      2792
                                                       
fs/ocfs2/xattr.c:3686:1:      2784
                                
drivers/media/dvb-frontends/cxd2841er.c:3639:1:      2784
                                                       
fs/ocfs2/super.c:2355:1:      2768
                                                      
net/sctp/socket.c:7632:1:      2768
                            
drivers/net/wireless/ralink/rt2x00/rt73usb.c:734:1:      2760
                              
drivers/net/ethernet/rocker/rocker_ofdpa.c:563:1:      2760
                                                      
net/rxrpc/input.c:1362:1:      2752
                         
drivers/net/wireless/ralink/rt2x00/rt2500pci.c:1323:1:      2752
                                
drivers/media/dvb-frontends/cxd2841er.c:3132:1:      2744
                                                     
fs/btrfs/disk-io.c:3341:1:      2720
                                
drivers/iio/common/ssp_sensors/ssp_spi.c:449:1:      2720
                                                            
fs/f2fs/gc.c:825:1:      2704
                                               
fs/xfs/libxfs/xfs_rmap.c:1348:1:      2696
                                               
fs/ocfs2/dlm/dlmmaster.c:2767:1:      2664
                                                     
lib/test_overflow.c:588:1:      2648
                                                   
net/core/rtnetlink.c:1700:1:      2648
                                       
drivers/gpu/drm/tinydrm/ili9225.c:260:1:      2616
                          
drivers/net/wireless/ralink/rt2x00/rt2500usb.c:591:1:      2616
                                                           
fs/f2fs/gc.c:1250:1:      2608
                                                        
fs/nfsd/export.c:652:1:      2608
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:6805:1:      2608
                                                              
mm/rmap.c:1627:1:      2600
                                                
net/bridge/br_netlink.c:1481:1:      2592
                                           
drivers/media/tuners/r820t.c:1327:1:      2576
                                  
drivers/media/dvb-frontends/stv090x.c:2069:1:      2544
                                         
drivers/scsi/qla2xxx/qla_isr.c:1257:1:      2544
                                                    
fs/btrfs/tree-log.c:3185:1:      2528
                                                        
drivers/md/md.c:8645:1:      2528
                                  
drivers/media/dvb-frontends/stv090x.c:2508:1:      2528
                                                            
lib/rbtree.c:481:1:      2520
                                                            
lib/rbtree.c:463:1:      2520
                                                        
mm/page_alloc.c:5041:1:      2512
                                                            
mm/migrate.c:576:1:      2512
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:4834:1:      2512
                                                     
net/rxrpc/recvmsg.c:608:1:      2488
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3181:1:      2488
                                    
drivers/firmware/efi/test/efi_test.c:688:1:      2480
                          
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:836:1:      2480
                              
drivers/media/pci/solo6x10/solo6x10-disp.c:289:1:      2472
                                                    
net/mac80211/util.c:2263:1:      2464
                       
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/anx9805.c:189:1:      2464
                                                               
mm/ksm.c:2180:1:      2456
                                              
fs/ocfs2/dlm/dlmrecovery.c:752:1:      2456
                                          
drivers/block/drbd/drbd_req.c:1624:1:      2448
                                       
drivers/input/mouse/cyapa_gen5.c:2434:1:      2440
                                                   
drivers/net/macsec.c:2597:1:      2432
                                            
drivers/scsi/fnic/fnic_fcs.c:918:1:      2424
                                                       
net/rxrpc/rxkad.c:399:1:      2400
                                                    
fs/nilfs2/segment.c:1530:1:      2392
                                                    
fs/cachefiles/rdwr.c:674:1:      2384
                                                    
mm/memory-failure.c:1925:1:      2384
                                                       
fs/userfaultfd.c:1843:1:      2384
                                                 
net/wireless/nl80211.c:4796:1:      2376
                                         
drivers/scsi/lpfc/lpfc_nvmet.c:1462:1:      2376
                                                       
fs/ocfs2/namei.c:2064:1:      2368
                         
drivers/net/wireless/ralink/rt2x00/rt2500usb.c:1122:1:      2368
                                        
drivers/infiniband/hw/hfi1/rc.c:2482:1:      2360
                                               
fs/ocfs2/dlm/dlmmaster.c:1013:1:      2352
                                
drivers/media/dvb-frontends/cxd2841er.c:3211:1:      2344
                                                 
net/wireless/nl80211.c:6130:1:      2328
                                    
drivers/input/touchscreen/ads7846.c:1459:1:      2312
                                                          
mm/swapfile.c:2236:1:      2304
                                                            
mm/migrate.c:726:1:      2304
                                                         
fs/ocfs2/dir.c:3107:1:      2304
                               
sound/soc/intel/haswell/sst-haswell-ipc.c:640:1:      2296
                                                       
net/smc/smc_cdc.c:323:1:      2296
                                           
drivers/media/i2c/saa6752hs.c:555:1:      2288
                                                 
net/wireless/nl80211.c:1586:1:      2272
          
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26034:1:      2272
                                                             
mm/shmem.c:1937:1:      2256
                                               
fs/xfs/xfs_log_recover.c:2008:1:      2256
                                                         
fs/f2fs/file.c:1189:1:      2248
                                               
net/ieee802154/nl802154.c:551:1:      2248
                                        
drivers/block/drbd/drbd_state.c:2039:1:      2240
                                                        
fs/ocfs2/namei.c:503:1:      2232
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:1681:1:      2224
                                                    
mm/memory-failure.c:1419:1:      2216
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:7378:1:      2216
                                                            
mm/madvise.c:441:1:      2208
                                                
drivers/net/virtio_net.c:984:1:      2200
                                  
drivers/media/dvb-frontends/stv0910.c:1613:1:      2192
                                
drivers/media/i2c/cx25840/cx25840-core.c:460:1:      2192
                         
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:5138:1:      2176
                                 
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c:830:1:      2168
                                  
drivers/isdn/hardware/eicon/message.c:5985:1:      2160
                              
drivers/media/pci/saa7134/saa7134-cards.c:8068:1:      2160
                                                 
arch/x86/kvm/emulate.c:2562:1:      2152
                             
drivers/net/wireless/ath/ath9k/ar9003_mac.c:158:1:      2152
                                              
fs/xfs/libxfs/xfs_alloc.c:1383:1:      2144
                                                     
lib/test_overflow.c:606:1:      2128
                                            
drivers/i2c/busses/i2c-fsi.c:638:1:      2128
                                                     
arch/x86/kvm/x86.c:4059:1:      2120
                                                       
fs/btrfs/scrub.c:3394:1:      2112
                                                     
block/blk-cgroup.c:1026:1:      2112
                                       
drivers/staging/erofs/unzip_vle.c:999:1:      2112
                                  
drivers/media/dvb-frontends/stv090x.c:4580:1:      2104
                                  
drivers/media/dvb-frontends/stv090x.c:2137:1:      2104
                           
drivers/net/ethernet/intel/igb/igb_ethtool.c:2079:1:      2104
                                          
drivers/scsi/qla4xxx/ql4_nx.c:3218:1:      2104
                                                          
fs/ntfs/mft.c:2764:1:      2096
                                                    
net/wireless/scan.c:1059:1:      2096
                                
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:4349:1:      2096
                                   
drivers/net/ethernet/broadcom/cnic.c:2725:1:      2096
                                                       
net/rxrpc/rxkad.c:499:1:      2088
                                      
drivers/net/bonding/bond_netlink.c:677:1:      2088
                                                              
mm/shmem.c:987:1:      2080
                                                         
fs/f2fs/debug.c:130:1:      2080
                        
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/anx9805.c:95:1:      2080
                                  
drivers/media/dvb-frontends/stv090x.c:1207:1:      2080
                                  
drivers/media/dvb-frontends/stv090x.c:1164:1:      2080
                                            
drivers/staging/pi433/rf69.c:613:1:      2080
                                                   
net/mac802154/iface.c:201:1:      2072
                                               
fs/ocfs2/dlm/dlmmaster.c:2050:1:      2064
                                  
drivers/media/dvb-frontends/stv090x.c:4774:1:      2064
                                                         
mm/compaction.c:959:1:      2056

after:

TOTAL warnings: 43
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:5653:1:     11880
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:4518:1:      7264
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3882:1:      5840
                                                     
lib/atomic64_test.c:250:1:      5656
                                                     
lib/atomic64_test.c:148:1:      5232
                           
drivers/net/wireless/ralink/rt2x00/rt73usb.c:1294:1:      4392
                         
drivers/net/wireless/ralink/rt2x00/rt2500pci.c:1047:1:      3904
                          
drivers/net/wireless/ralink/rt2x00/rt2500usb.c:891:1:      3848
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:2717:1:      3792
                                  
drivers/media/dvb-frontends/stv090x.c:3431:1:      3512
                                                            
mm/vmscan.c:1497:1:      3488
                                                      
fs/fscache/stats.c:286:1:      3336
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:8659:1:      3288
                                  
drivers/media/dvb-frontends/stv090x.c:3090:1:      3032
                                                     
lib/test_overflow.c:483:1:      2976
          
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:16563:1:      2976
                           
drivers/net/wireless/ralink/rt2x00/rt61pci.c:1647:1:      2944
                                  
drivers/media/dvb-frontends/stv090x.c:1595:1:      2712
                                          
drivers/scsi/fnic/fnic_trace.c:451:1:      2640
                                  
drivers/media/dvb-frontends/stv0910.c:1547:1:      2624
          
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:16905:1:      2616
                                                 
net/wireless/nl80211.c:2102:1:      2544
                         
drivers/net/wireless/ralink/rt2x00/rt2800lib.c:2420:1:      2512
                                                     
net/core/ethtool.c:2872:1:      2496
                                                       
fs/jbd2/commit.c:1129:1:      2480
                                  
drivers/media/dvb-frontends/stv090x.c:4265:1:      2472
                                                 
net/sched/cls_flower.c:1286:1:      2392
                                                  
fs/btrfs/relocation.c:1149:1:      2368
                                               
drivers/acpi/nfit/core.c:3213:1:      2352
                                           
drivers/scsi/lpfc/lpfc_attr.c:510:1:      2320
                           
drivers/net/wireless/ralink/rt2x00/rt61pci.c:2631:1:      2272
                
drivers/net/wireless/realtek/rtl818x/rtl8180/rtl8225se.c:431:1:      2264
                                
drivers/iio/common/ssp_sensors/ssp_spi.c:449:1:      2176
                    
drivers/staging/rtlwifi/btcoexist/halbtc8822b2ant.c:3545:1:      2168
                                                       
fs/ocfs2/super.c:1234:1:      2160
                                                       
fs/ocfs2/namei.c:1691:1:      2152
          
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:26034:1:      2144
                                                      
kernel/rcu/tree.c:2239:1:      2136
                          
drivers/net/wireless/ralink/rt2x00/rt2400pci.c:909:1:      2112
                           
drivers/net/wireless/ralink/rt2x00/rt61pci.c:1963:1:      2080
                           
drivers/net/wireless/ralink/rt2x00/rt61pci.c:2497:1:      2080
                                        
drivers/scsi/lpfc/lpfc_debugfs.c:978:1:      2072
                                   
drivers/scsi/mpt3sas/mpt3sas_scsih.c:9467:1:      2072

Which is very promising improvement I would say.


More information about the Gcc-bugs mailing list