[Bug other/21823] MAXPATHLEN usage in [gcc]/fixincludes

egallager at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Fri Sep 21 02:03:00 GMT 2018


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=21823

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |easyhack
                 CC|                            |pinskia at gcc dot gnu.org

--- Comment #5 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to Alfred M. Szmidt from comment #4)
>    > Created attachment 9857 [details]
>    > Don't use arbitrary limits.
>    > 
>    > The following fixes fixincludes.
>    > 
>    > fixincludes/ChangeLog
>    > 2005-09-16  Alfred M. Szmidt  <ams@gnu.org>
>    > 
>    > 	* fixincl.c (quoted_file_exists): Use xmalloc to allocate memory
>    > 	for FNAME.
>    > 	(create_file): Use xmalloc to allocate memory for FNAME.
>    > 
>    > 	* server.c (server_setup): Use dynamic allocation for BUFF.
> 
>    Please send this patch to the gcc-patches mailing list for review, if it
> still
>    applies
> 
> MAXPATHLEN is still used in fixincludes.  Seeing that this patch is
> over 10 years, I am not sure it even applies and thus a good idea to
> forward it to gcc-patches for review.  The fix is simple enough in
> fixincludes (simply use xmalloc).

ok, adding "easyhack" keyword then


More information about the Gcc-bugs mailing list