[Bug gcov-profile/77698] Unrolled loop not considered hot after profiling
marxin at gcc dot gnu.org
gcc-bugzilla@gcc.gnu.org
Tue Oct 9 11:43:00 GMT 2018
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77698
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |ASSIGNED
--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
Confirmed, I've got patch candidate for it:
diff --git a/gcc/ipa-profile.c b/gcc/ipa-profile.c
index c74f4a4a41d..7065af59ba9 100644
--- a/gcc/ipa-profile.c
+++ b/gcc/ipa-profile.c
@@ -533,11 +533,10 @@ ipa_profile (void)
cumulated_size * 100.0 / overall_size);
}
- if (threshold > get_hot_bb_threshold ()
- || in_lto_p)
+ if (in_lto_p)
{
if (dump_file)
- fprintf (dump_file, "Threshold updated.\n");
+ fprintf (dump_file, "Setting hotness threshold in LTO mode.\n");
set_hot_bb_threshold (threshold);
}
}
With the patch applied, I see following .S diff:
iff -u before.s after.s
--- before.s 2018-10-09 13:40:03.464360367 +0200
+++ after.s 2018-10-09 13:38:46.246736676 +0200
@@ -56,6 +56,8 @@
movq %rax, (%rdi,%rcx,8)
cmpq %r9, %rdx
je .L23
+ .p2align 4,,10
+ .p2align 3
.L6:
movq j(%rip), %r10
movq (%rsi), %r8
Which is hopefully what you expect to happen?
More information about the Gcc-bugs
mailing list