[Bug gcov-profile/84107] indirect call profiling broken with multiple DSOs

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84107

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
"Large symbols and symbols that must exist in exactly one instance in the
running program probably should be a part of (nonexistent) libgcov.so.0."

which are those?  I expected individual gcov "instances" to live across
dynamic object lifetime.  That is, does a shared libgcov fix the case
of dlopen()ing and dlclose()ing shared objects (multiple times)?

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Author: marxin
Date: Thu Oct  4 12:41:14 2018
New Revision: 264840

URL: https://gcc.gnu.org/viewcvs?rev=264840&root=gcc&view=rev
Log:
Fix divergence in indirect profiling (PR gcov-profile/84107).

2018-10-04  Martin Liska  <mliska@suse.cz>

        PR gcov-profile/84107
        * tree-profile.c (init_ic_make_global_vars):
        Remove ic_void_ptr_var and ic_gcov_type_ptr_var.
        Come up with new ic_tuple* variables.  Emit
        __gcov_indirect_call{,_topn} variables.
        (gimple_gen_ic_profiler): Access the variable
        and emit gimple.
        (gimple_gen_ic_func_profiler): Access
        __gcov_indirect_call.callee field.
        (gimple_init_gcov_profiler): Use ptr_type_node.
        * value-prof.c (gimple_ic): Use ptr_type_node.
2018-10-04  Martin Liska  <mliska@suse.cz>

        PR gcov-profile/84107
        * libgcov-profiler.c (__gcov_indirect_call):
        Change type to indirect_call_tuple.
        (struct indirect_call_tuple): New struct.
        (__gcov_indirect_call_topn_profiler): Change type.
        (__gcov_indirect_call_profiler_v2): Use the new
        variables.
        * libgcov.h (struct indirect_call_tuple): New struct
        definition.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-profile.c
    trunk/gcc/value-prof.c
    trunk/libgcc/ChangeLog
    trunk/libgcc/libgcov-profiler.c
    trunk/libgcc/libgcov.h