[Bug fortran/88249] ICE in gfc_resolve_filepos, at fortran/io.c:2853

kargl at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Fri Nov 30 23:26:00 GMT 2018


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88249

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kargl at gcc dot gnu.org

--- Comment #2 from kargl at gcc dot gnu.org ---
Better.

Index: gcc/fortran/gfortran.h
===================================================================
--- gcc/fortran/gfortran.h      (revision 266386)
+++ gcc/fortran/gfortran.h      (working copy)
@@ -3374,7 +3374,7 @@ bool gfc_resolve_open (gfc_open *);
 void gfc_free_close (gfc_close *);
 bool gfc_resolve_close (gfc_close *);
 void gfc_free_filepos (gfc_filepos *);
-bool gfc_resolve_filepos (gfc_filepos *);
+bool gfc_resolve_filepos (gfc_filepos *, locus *);
 void gfc_free_inquire (gfc_inquire *);
 bool gfc_resolve_inquire (gfc_inquire *);
 void gfc_free_dt (gfc_dt *);
Index: gcc/fortran/resolve.c
===================================================================
--- gcc/fortran/resolve.c       (revision 266386)
+++ gcc/fortran/resolve.c       (working copy)
@@ -11544,7 +11544,7 @@ start:
        case EXEC_ENDFILE:
        case EXEC_REWIND:
        case EXEC_FLUSH:
-         if (!gfc_resolve_filepos (code->ext.filepos))
+         if (!gfc_resolve_filepos (code->ext.filepos, &code->loc))
            break;

          resolve_branch (code->ext.filepos->err, code);
Index: gcc/fortran/io.c
===================================================================
--- gcc/fortran/io.c    (revision 266386)
+++ gcc/fortran/io.c    (working copy)
@@ -2834,22 +2834,21 @@ cleanup:


 bool
-gfc_resolve_filepos (gfc_filepos *fp)
+gfc_resolve_filepos (gfc_filepos *fp, locus *where)
 {
   RESOLVE_TAG (&tag_unit, fp->unit);
   RESOLVE_TAG (&tag_iostat, fp->iostat);
   RESOLVE_TAG (&tag_iomsg, fp->iomsg);
-  if (!gfc_reference_st_label (fp->err, ST_LABEL_TARGET))
-    return false;

-  if (!fp->unit && (fp->iostat || fp->iomsg))
+  if (!fp->unit && (fp->iostat || fp->iomsg || fp->err))
     {
-      locus where;
-      where = fp->iostat ? fp->iostat->where : fp->iomsg->where;
-      gfc_error ("UNIT number missing in statement at %L", &where);
+      gfc_error ("UNIT number missing in statement at %L", where);
       return false;
     }

+  if (!gfc_reference_st_label (fp->err, ST_LABEL_TARGET))
+    return false;
+
   if (fp->unit->expr_type == EXPR_CONSTANT
       && fp->unit->ts.type == BT_INTEGER
       && mpz_sgn (fp->unit->value.integer) < 0)


More information about the Gcc-bugs mailing list