[Bug libstdc++/64883] FAIL: 17_intro/headers/c++*/all_attributes.cc (test for excess errors) on x86_64-apple-darwin10

iains at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Tue Nov 20 19:55:00 GMT 2018


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64883

--- Comment #56 from Iain Sandoe <iains at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #55)
> (In reply to Jonathan Wakely from comment #54)
> > (In reply to Iain Sandoe from comment #53)
> > > well, the point was that we can file a bug/radar against current system
> > > headers using things outside the implementation space, but that won't fix
> > > things retrospectively.
> > 
> > Why do we need to fix it?
> > 
> > It's not our problem.
> 
> fair enough, so the work-arounds for the test cases will be enough to solve
> this (and I can check those on my next Darwin10 build).

Essentially comment #40 + update for c++20 fixes (works around the issue on)
Darwin10/9.

Pretty sure that's what Jonathan has in his patch... 

diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc
b/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc
index b6ff8c4..0e7dcf7 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++1998/all_attributes.cc
@@ -21,9 +21,9 @@
 // Ensure the library only uses the __name__ form for attributes.
 // Don't test 'const' because it is reserved anyway.
 #define abi_tag 1
-#define always_inline 1
 #ifndef __APPLE__
 // darwin headers use these, see PR 64883
+# define always_inline 1
 # define deprecated 1
 # define noreturn 1
 # define visibility 1
diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2011/all_attributes.cc
b/libstdc++-v3/testsuite/17_intro/headers/c++2011/all_attributes.cc
index 33b759f..24b5691 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++2011/all_attributes.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2011/all_attributes.cc
@@ -21,9 +21,9 @@
 // Ensure the library only uses the __name__ form for attributes.
 // Don't test 'const' and 'noreturn' because they are reserved anyway.
 #define abi_tag 1
-#define always_inline 1
 #ifndef __APPLE__
 // darwin headers use these, see PR 64883
+# define always_inline 1
 # define visibility 1
 # define deprecated 1
 #endif
diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2014/all_attributes.cc
b/libstdc++-v3/testsuite/17_intro/headers/c++2014/all_attributes.cc
index dbea4fe..d6cc2c9 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++2014/all_attributes.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2014/all_attributes.cc
@@ -21,9 +21,9 @@
 // Ensure the library only uses the __name__ form for attributes.
 // Don't test 'const' and 'noreturn' because they are reserved anyway.
 #define abi_tag 1
-#define always_inline 1
 #ifndef __APPLE__
 // darwin headers use these, see PR 64883
+# define always_inline 1
 # define deprecated 1
 # define visibility 1
 #endif
diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2017/all_attributes.cc
b/libstdc++-v3/testsuite/17_intro/headers/c++2017/all_attributes.cc
index 0a92ae6..9f60190 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++2017/all_attributes.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2017/all_attributes.cc
@@ -21,9 +21,9 @@
 // Ensure the library only uses the __name__ form for attributes.
 // Don't test 'const' and 'noreturn' because they are reserved anyway.
 #define abi_tag 1
-#define always_inline 1
 #ifndef __APPLE__
 // darwin headers use this, see PR 64883
+# define always_inline 1
 # define visibility 1
 #endif
 #define packed 1
diff --git a/libstdc++-v3/testsuite/17_intro/headers/c++2020/all_attributes.cc
b/libstdc++-v3/testsuite/17_intro/headers/c++2020/all_attributes.cc
index 766c7b6..a5fca4c 100644
--- a/libstdc++-v3/testsuite/17_intro/headers/c++2020/all_attributes.cc
+++ b/libstdc++-v3/testsuite/17_intro/headers/c++2020/all_attributes.cc
@@ -21,9 +21,9 @@
 // Ensure the library only uses the __name__ form for attributes.
 // Don't test 'const' and 'noreturn' because they are reserved anyway.
 #define abi_tag 1
-#define always_inline 1
 #ifndef __APPLE__
 // darwin headers use this, see PR 64883
+# define always_inline 1
 # define visibility 1
 #endif
 #define packed 1


More information about the Gcc-bugs mailing list