[Bug libstdc++/85843] warning: base class ‘class std::exception’ should be explicitly initialized in the copy constructor [-Wextra]

[sgk at troutmask dot apl.washington.edu]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85843

--- Comment #8 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Sun, May 20, 2018 at 11:50:54PM +0000, redi at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85843
> 
> Jonathan Wakely <redi at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|ASSIGNED                    |RESOLVED
>          Resolution|---                         |FIXED
> 
> --- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
> (In reply to Steve Kargl from comment #5)
> > ../gcc/configure --prefix=$HOME/work/x --enable-languages=c,fortran \
> >   --enable-bootstrap --disable-nls --enable-checking=yes \
> >   --enable-maintainer-mode
>     ^^^^^^^^^^^^^^^^^^^^^^^^
> ../../../../../gcc/libstdc++-v3/src/c++11/cow-stdexcept.cc:58:3: error: base
> class 'class std::exception' should be explicitly initialized in the copy
> constructor
>  [-Werror=extra]
>  ^^^^^^^^^^^^^^^

--enable-maintainer-mode is required when adding a new intrinsic
subprogram to libgfortran. 

IMNSHO, every committer should be required to include -Werror 
and -Werro-extra.  Introducing a patch and new code that causes
a new warning is broken by definition.

> The "error" is a warning, that fails the build because you're using -Werror
> (via maintainer-mode) so you can save yourself a day next time.

I have weekends to work on gfortran.  Yeah, I know, it's only
Fortran.  It's good to know you've volunteer to implement Fortran
2018's RANDOM_INIT, so that I won't need to use --enable-maintainer-mode.

IOW, it is disrespectful to blame one's mistakes on others because
they need to use functionality to get their work done. 

> It's fixed now.

Should have never been broken.