[Bug libitm/86294] New: comparison is always true due to limited range of data type [-Werror=type-limits]

[um at mutluit dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=86294

            Bug ID: 86294
           Summary: comparison is always true due to limited range of data
                    type [-Werror=type-limits]
           Product: gcc
           Version: 9.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libitm
          Assignee: unassigned at gcc dot gnu.org
          Reporter: um at mutluit dot com
  Target Milestone: ---

If warnings are treated as error (I think that's the default, or gets
implicitly activated if -Wall -Wextra has been given), then if
-Wno-error=type-limits has not been defined, then the following error gets
reported and the build aborts:

../../../gcc_trunk/libitm/method-ml.cc: In member function 'virtual bool
{anonymous}::ml_wt_dispatch::supports(unsigned int)':
../../../gcc_trunk/libitm/method-ml.cc:650:35: error: comparison is always true
due to limited range of data type [-Werror=type-limits]
     return (number_of_threads * 2 <= ml_mg::OVERFLOW_RESERVE);
             ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~