[Bug middle-end/82063] issues with arguments enabled by -Wall

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82063

--- Comment #11 from Martin Sebor <msebor at gcc dot gnu.org> ---
Author: msebor
Date: Fri Jul 20 20:51:20 2018
New Revision: 262910

URL: https://gcc.gnu.org/viewcvs?rev=262910&root=gcc&view=rev
Log:
PR middle-end/82063 - issues with arguments enabled by -Wall

gcc/ada/ChangeLog:

        PR middle-end/82063
        * gcc-interface/misc.c (gnat_handle_option): Change function argument
        to HOST_WIDE_INT.

gcc/brig/ChangeLog:

        PR middle-end/82063
        * brig/brig-lang.c (brig_langhook_handle_option): Change function
        argument to HOST_WIDE_INT.

gcc/c-family/ChangeLog:

        PR middle-end/82063
        * c-common.h (c_common_handle_option): Change function argument
        to HOST_WIDE_INT.
        * c-opts.c (c_common_init_options): Same.
        (c_common_handle_option): Same.  Remove special handling of
        OPT_Walloca_larger_than_ and OPT_Wvla_larger_than_.
        * c.opt (-Walloc-size-larger-than, -Walloca-larger-than): Change
        options to take a HOST_WIDE_INT argument and accept a byte-size
        suffix.  Initialize.
        (-Wvla-larger-than): Same.
        (-Wno-alloc-size-larger-than, -Wno-alloca-larger-than): New.
        (-Wno-vla-larger-than): Same.

gcc/fortran/ChangeLog:

        PR middle-end/82063
        * gfortran.h (gfc_handle_option): Change function argument
        to HOST_WIDE_INT.
        * options.c (gfc_handle_option): Same.

gcc/go/ChangeLog:

        PR middle-end/82063
        * go-lang.c (go_langhook_handle_option): Change function argument
        to HOST_WIDE_INT.

gcc/lto/ChangeLog:

        PR middle-end/82063
        * lto-lang.c (lto_handle_option): Change function argument
        to HOST_WIDE_INT.

gcc/testsuite/ChangeLog:

        PR middle-end/82063
        * gcc/testsuite/c-c++-common/pr68657-1.c: Adjust.
        * gcc/testsuite/c-c++-common/pr68657-2.c: Same.
        * gcc/testsuite/c-c++-common/pr68657-3.c: Same.
        * gcc.dg/Walloc-size-larger-than-16.c: Same.
        * gcc.dg/Walloca-larger-than.c: New test.
        * gcc.dg/Walloca-larger-than-2.c: New test.
        * gcc.dg/Wframe-larger-than-2.c: New test.
        * gcc.dg/Wlarger-than3.c: New test.
        * gcc.dg/Wvla-larger-than-3.c: New test.
        * gcc.dg/pr42611.c: Adjust.
        * gnat.dg/frame_overflow.adb: Same.

gcc/ChangeLog:

        PR middle-end/82063
        * builtins.c (expand_builtin_alloca): Adjust.
        * calls.c (alloc_max_size): Simplify.
        * cgraphunit.c (cgraph_node::expand): Adjust.
        * common.opt (larger_than_size, warn_frame_larger_than): Remove
        variables.
        (frame_larger_than_size): Same.
        (-Wframe-larger-than, -Wlarger-than, -Wstack-usage): Change options
        to take a HOST_WIDE_INT argument and accept a byte-size suffix.
        Initialize.
        * doc/invoke.texi (GCC Command Options): Document option arguments.
        Explain byte-size arguments and suffixes.
        (-Wvla-larger-than, -Wno-alloc-size-larger-than): Update.
        (-Wno-alloca-larger-than, -Wno-vla-larger-than): Same.
        (-Wframe-larger-than, -Wlarger-than, -Wstack-usage): Same.
        * doc/options.texi (UInteger): Expand.
        (Host_Wide_Int, ByteSize): Document new properties.
        * final.c (final_start_function_1): Include sizes in an error message.
        * function.c (frame_offset_overflow): Same.
        * gimple-ssa-warn-alloca.c (pass_walloca::gate): Adjust.
        (alloca_call_type_by_arg): Change function argument to HOST_WIDE_INT.
        Diagnose unbounded alloca calls only for limits of less than
        PTRDIFF_MAX.
        (alloca_call_type): Adjust.  Diagnose possibly out-of-bounds alloca
        calls and VLA size only for limits of less than PTRDIFF_MAX.  Same
        for alloca(0).
        (pass_walloca::execute): Adjust.  Diagnose alloca calls in loops
        only for limits of less than PTRDIFF_MAX.
        * langhooks-def.h (lhd_handle_option): Change function argument
        to HOST_WIDE_INT.
        * langhooks.c (lhd_handle_option): Same.
        * langhooks.h (handle_option): Same.
        * opt-functions.awk (switch_bit_fields): Handle Host_Wide_Int and
        ByteSize flags.
        (var_type, var_type_struct): Same.
        (var_set): Handle ByteSize flag.
        * optc-gen.awk: Add comments to output to ease debugging.  Make
        use of HOST_WIDE_INT where appropriate.
        * opts-gen-save.awk:  Use %lx to format unsigned long.
        * opth-gen.awk: Change function argument to HOST_WIDE_INT.
        * opts-common.c (integral_argument): Return HOST_WIDE_INT and add
        arguments.  Parse bytes-size suffixes.
        (enum_arg_to_value): Change function argument to HOST_WIDE_INT.
        (enum_value_to_arg): Same.
        (decode_cmdline_option): Handle cl_host_wide_int.  Adjust.
        (handle_option): Adjust.
        (generate_option): Change function argument to HOST_WIDE_INT.
        (cmdline_handle_error): Adjust.
        (read_cmdline_option): Change function argument to HOST_WIDE_INT.
        (set_option): Change function argument to HOST_WIDE_INT.
        (option_enabled): Handle cl_host_wide_int.
        (get_option_state): Handle CLVC_SIZE.
        (control_warning_option): Same.
        * opts.c (common_handle_option): Change function argument to
        HOST_WIDE_INT.  Remove handling of OPT_Walloca_larger_than_ and
        OPT_Wvla_larger_than_.
        * opts.h (enum cl_var_type): Add an enumerator.
        * stor-layout.c (layout_decl): Print a more meaningful warning.
        * toplev.c (output_stack_usage): Adjust.


Added:
    trunk/gcc/testsuite/gcc.dg/Walloca-larger-than-2.c
    trunk/gcc/testsuite/gcc.dg/Walloca-larger-than.c
    trunk/gcc/testsuite/gcc.dg/Wframe-larger-than-2.c
    trunk/gcc/testsuite/gcc.dg/Wlarger-than3.c
    trunk/gcc/testsuite/gcc.dg/Wvla-larger-than-3.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/gcc-interface/misc.c
    trunk/gcc/brig/ChangeLog
    trunk/gcc/brig/brig-lang.c
    trunk/gcc/builtins.c
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-common.h
    trunk/gcc/c-family/c-opts.c
    trunk/gcc/c-family/c.opt
    trunk/gcc/calls.c
    trunk/gcc/cgraphunit.c
    trunk/gcc/common.opt
    trunk/gcc/doc/invoke.texi
    trunk/gcc/doc/options.texi
    trunk/gcc/final.c
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/options.c
    trunk/gcc/function.c
    trunk/gcc/gimple-ssa-warn-alloca.c
    trunk/gcc/go/ChangeLog
    trunk/gcc/go/go-lang.c
    trunk/gcc/langhooks-def.h
    trunk/gcc/langhooks.c
    trunk/gcc/langhooks.h
    trunk/gcc/lto/ChangeLog
    trunk/gcc/lto/lto-lang.c
    trunk/gcc/opt-functions.awk
    trunk/gcc/optc-gen.awk
    trunk/gcc/optc-save-gen.awk
    trunk/gcc/opth-gen.awk
    trunk/gcc/opts-common.c
    trunk/gcc/opts.c
    trunk/gcc/opts.h
    trunk/gcc/stor-layout.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/c-c++-common/pr68657-2.c
    trunk/gcc/testsuite/c-c++-common/pr68657-3.c
    trunk/gcc/testsuite/gcc.dg/Walloc-size-larger-than-16.c
    trunk/gcc/testsuite/gcc.dg/pr42611.c
    trunk/gcc/testsuite/gnat.dg/frame_overflow.adb
    trunk/gcc/toplev.c