[Bug c/81417] -Wsign-compare should print types being compared
aldyh at gcc dot gnu.org
gcc-bugzilla@gcc.gnu.org
Wed Sep 13 16:42:00 GMT 2017
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81417
--- Comment #8 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Author: aldyh
Date: Wed Sep 13 16:42:07 2017
New Revision: 252353
URL: https://gcc.gnu.org/viewcvs?rev=252353&root=gcc&view=rev
Log:
PR c/81417
* c-array-notation.c (fix_builtin_array_notation_fn): Update calls to
build_conditional_expr.
* c-parser.c (c_parser_conditional_expression): Create locations for
EXP1 and EXP2 from their source ranges. Pass the locations down to
build_conditional_expr.
* c-tree.h (build_conditional_expr): Update declaration.
* c-typeck.c (build_conditional_expr): Add location_t parameters.
For -Wsign-compare, also print the types.
* input.c (make_location): New overload.
* input.h (make_location): Declare.
* objc-next-runtime-abi-02.c (build_v2_build_objc_method_call): Update
a call to build_conditional_expr.
* Wsign-compare-1.c: New test.
* gcc.dg/compare1.c: Adjust dg-bogus.
* gcc.dg/compare2.c: Likewise.
* gcc.dg/compare3.c: Likewise.
* gcc.dg/compare7.c: Likewise.
* gcc.dg/compare8.c: Likewise.
* gcc.dg/compare9.c: Likewise.
* gcc.dg/pr11492.c: Likewise.
Added:
branches/range-gen2/gcc/testsuite/gcc.dg/Wsign-compare-1.c
Modified:
branches/range-gen2/gcc/ChangeLog
branches/range-gen2/gcc/c/ChangeLog
branches/range-gen2/gcc/c/c-array-notation.c
branches/range-gen2/gcc/c/c-parser.c
branches/range-gen2/gcc/c/c-tree.h
branches/range-gen2/gcc/c/c-typeck.c
branches/range-gen2/gcc/input.c
branches/range-gen2/gcc/input.h
branches/range-gen2/gcc/objc/ChangeLog
branches/range-gen2/gcc/objc/objc-next-runtime-abi-02.c
branches/range-gen2/gcc/testsuite/ChangeLog
branches/range-gen2/gcc/testsuite/gcc.dg/compare1.c
branches/range-gen2/gcc/testsuite/gcc.dg/compare2.c
branches/range-gen2/gcc/testsuite/gcc.dg/compare3.c
branches/range-gen2/gcc/testsuite/gcc.dg/compare7.c
branches/range-gen2/gcc/testsuite/gcc.dg/compare8.c
branches/range-gen2/gcc/testsuite/gcc.dg/compare9.c
branches/range-gen2/gcc/testsuite/gcc.dg/pr11492.c
More information about the Gcc-bugs
mailing list