[Bug libstdc++/82745] Fails to warn on narrowing conversion by std::forward (e.g. when calling make_unique)

helge at penne dot no gcc-bugzilla@gcc.gnu.org
Mon Oct 30 16:20:00 GMT 2017


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82745

--- Comment #11 from helge at penne dot no ---
(In reply to Jonathan Wakely from comment #10)
> This is still the same known problem already described in PR 80472 and PR
> 58876.

It is the same root cause, yes.  PR 58876 is about a different warning. 
Depending on how this is to be fixed, changes may be needed a different part of
the libstdc++ code base to fix the problem I found with make_unique.  So
perhaps not a straight duplicate, but very closely related.

The push/pop solution mentioned in PR 58876 seems interesting, but depends on
PR 80472 being fixed first.  I hope someone can get around to this, given that
it blocks the "easy" fix for PR 58876 and this make_unique issue.

I guess I have to sit tight for a while then, and hope that PR 58876 gets
assigned to someone, so that PR 80472 and this one has a chance of getting
fixed as well.

In the mean time, we'll probably solve this in our own code base by writing our
own wrapper for make_unique to make it safe.

Thank you for your patience. :-)


More information about the Gcc-bugs mailing list