[Bug c/81156] GCC fails to compile a formula with tgmath.h

jsm28 at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Wed Nov 15 01:54:00 GMT 2017


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81156

--- Comment #6 from Joseph S. Myers <jsm28 at gcc dot gnu.org> ---
Author: jsm28
Date: Wed Nov 15 01:53:45 2017
New Revision: 254749

URL: https://gcc.gnu.org/viewcvs?rev=254749&root=gcc&view=rev
Log:
Add __builtin_tgmath for better tgmath.h implementation (bug 81156).

Various implementations of C99/C11 <tgmath.h> have the property that
their macro expansions contain many copies of the macro arguments, so
resulting in exponential blowup of the size of macro expansions where
a call to such a macro contains other such calls in the macro
arguments.

This patch adds a (C-only) language feature __builtin_tgmath designed
to avoid this problem by implementing the <tgmath.h> function
selection rules directly in the compiler.  The effect is that
type-generic macros can be defined simply as

#define pow(a, b) __builtin_tgmath (powf, pow, powl, \
                                    cpowf, cpow, cpowl, a, b)

as in the example added to the manual, with each macro argument
expanded exactly once.  The details of __builtin_tgmath are as
described in the manual.  This is C-only since C++ uses function
overloading and just defines <ctgmath> to include <ccomplex> and
<cmath>.

__builtin_tgmath handles C99/C11 type-generic macros, and _FloatN,
_FloatNx and decimal floating-point types (following the proposed
resolution to the floating-point TS DR#9 that makes the rules for
finding a common type from arguments to a type-generic macro follow
the usual arithmetic conversions after adjustment of integer arguments
to _Decimal64 or double - or to _Complex double in the case of GNU
complex integer arguments).

Type-generic macros for functions from TS 18661 that round their
results to a narrower type are handled, but there are still some
unresolved questions regarding such macros so further changes in that
regard may be needed in future.  The current implementation follows an
older version of the DR#13 resolution (allowing a function for a
wide-enough argument type to be selected if no exactly-matching
function is available), but with appropriate calls to __builtin_tgmath
is still fully compatible with the latest version of the resolution
(not yet in the DR log), and allowing such not-exactly-matching
argument types to be chosen in that case avoids needing another
special case to treat integers as _Float64 instead of double in
certain cases.

Regarding other possible language/library features, not currently
implemented in GCC:

* Imaginary types could be naturally supported by allowing cases where
  the type-generic type is an imaginary type T and arguments or return
  types may be T (as at present), or the corresponding real type to T
  (as at present), or (new) the corresponding real type if T is real
  or imaginary but T if T is complex.  (tgmath.h would need a series
  of functions such as

  static inline _Imaginary double
  __sin_imag (_Imaginary double __x)
  {
    return _Imaginary_I * sinh (__imag__ __x);
  }

  to be used in __builtin_tgmath calls.)

* __builtin_tgmath would use the constant rounding direction in the
  presence of support for the FENV_ROUND / FENV_DEC_ROUND pragmas.
  Support for those would also require a new __builtin_<something> to
  cause a non-type-generic call to use the constant rounding
  direction (it seems cleaner to add a new __builtin_<something> when
  required than to make __builtin_tgmath handle a non-type-generic
  case with only one function argument).

* TS 18661-5 __STDC_TGMATH_OPERATOR_EVALUATION__ would require new
  __builtin_<something> that evaluates with excess range and precision
  like arithmetic operators do.

* The proposed C bindings for IEEE 754-2018 augmented arithmetic
  operations involve struct return types.  As currently implemented
  __builtin_tgmath does not handle those, but support could be added.

There are many error cases that the implementation diagnoses.  I've
tried to ensure reasonable error messages for erroneous uses of
__builtin_tgmath, but the errors for erroneous uses of the resulting
type-generic macros (that is, when the non-function arguments have
inappropriate types) are more important as they are more likely to be
seen by users.

GCC's own tgmath.h, as used for some targets, is updated in this
patch.  I've tested those changes minimally, via adjusting
gcc.dg/c99-tgmath-* locally to use that tgmath.h version.  I've also
run the glibc testsuite (which has much more thorough tests of
correctness of tgmath.h function selection) with a glibc patch to use
__builtin_tgmath in glibc's tgmath.h.

Bootstrapped with no regressions on x86_64-pc-linux-gnu.

        PR c/81156

gcc:
        * doc/extend.texi (Other Builtins): Document __builtin_tgmath.
        * ginclude/tgmath.h (__tg_cplx, __tg_ldbl, __tg_dbl, __tg_choose)
        (__tg_choose_2, __tg_choose_3, __TGMATH_REAL_1_2)
        (__TGMATH_REAL_2_3): Remove macros.
        (__TGMATH_CPLX, __TGMATH_CPLX_2, __TGMATH_REAL, __TGMATH_REAL_2)
        (__TGMATH_REAL_3, __TGMATH_CPLX_ONLY): Define using
        __builtin_tgmath.
        (frexp, ldexp, nexttoward, scalbn, scalbln): Define using
        __TGMATH_REAL_2.
        (remquo): Define using __TGMATH_REAL_3.

gcc/c:
        * c-parser.c (check_tgmath_function): New function.
        (enum tgmath_parm_kind): New enum.
        (c_parser_postfix_expression): Handle __builtin_tgmath.

gcc/c-family:
        * c-common.c (c_common_reswords): Add __builtin_tgmath.
        * c-common.h (enum rid): Add RID_BUILTIN_TGMATH.

gcc/testsuite:
        * gcc.dg/builtin-tgmath-1.c, gcc.dg/builtin-tgmath-2.c,
        gcc.dg/builtin-tgmath-err-1.c, gcc.dg/builtin-tgmath-err-2.c,
        gcc.dg/dfp/builtin-tgmath-dfp-err.c,
        gcc.dg/dfp/builtin-tgmath-dfp.c: New tests.

Added:
    trunk/gcc/testsuite/gcc.dg/builtin-tgmath-1.c
    trunk/gcc/testsuite/gcc.dg/builtin-tgmath-2.c
    trunk/gcc/testsuite/gcc.dg/builtin-tgmath-err-1.c
    trunk/gcc/testsuite/gcc.dg/builtin-tgmath-err-2.c
    trunk/gcc/testsuite/gcc.dg/dfp/builtin-tgmath-dfp-err.c
    trunk/gcc/testsuite/gcc.dg/dfp/builtin-tgmath-dfp.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-common.c
    trunk/gcc/c-family/c-common.h
    trunk/gcc/c/ChangeLog
    trunk/gcc/c/c-parser.c
    trunk/gcc/doc/extend.texi
    trunk/gcc/ginclude/tgmath.h
    trunk/gcc/testsuite/ChangeLog


More information about the Gcc-bugs mailing list