[Bug fortran/79165] 100% compile-time increase for polyhedron aermod by r244581

rguenther at suse dot de gcc-bugzilla@gcc.gnu.org
Tue Jan 24 09:31:00 GMT 2017


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79165

--- Comment #16 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 24 Jan 2017, m.ostapenko at samsung dot com wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79165
> 
> Maxim Ostapenko <m.ostapenko at samsung dot com> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |m.ostapenko at samsung dot com
> 
> --- Comment #15 from Maxim Ostapenko <m.ostapenko at samsung dot com> ---
> (In reply to David Malcolm from comment #13)
> > What's the purpose of the linemap_add call at line 4761?
> 
> I used this to add a source location for TRANSLATION_UNIT_DECL as was discussed
> in pr79061. Dunno, maybe, I've reverted my patch for pr79061 so this change
> isn't present anymore. As Richard pointed out in related mail it would be
> better to do something like this:
> 
> +    tree tu = build_decl (UNKNOWN_LOCATION, TRANSLATION_UNIT_DECL,
> -                       name, NULL_TREE);
> +                       get_identifier (main_input_filename),
> +                       NULL_TREE);
> 
> and use DECL_NAME (translation_unit_decl) later instead of creating new source
> location.

Well, rather pass down get_identifier (main_input_fileame) in the callers.

Richard.


More information about the Gcc-bugs mailing list