[Bug c/81544] attribute noreturn and warn_unused_result on the same function accepted

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81544

--- Comment #3 from Martin Sebor <msebor at gcc dot gnu.org> ---
Author: msebor
Date: Thu Dec  7 16:32:03 2017
New Revision: 255469

URL: https://gcc.gnu.org/viewcvs?rev=255469&root=gcc&view=rev
Log:
PR c/81544 - attribute noreturn and warn_unused_result on the same function
accepted
PR c/81566 - invalid attribute aligned accepted on functions

gcc/ada/ChangeLog:

        PR c/81544
        * gcc-interface/utils.c (gnat_internal_attribute_table): Initialize
        new member of struct attribute_spec.

gcc/c/ChangeLog:

        PR c/81544
        * c-decl.c (c_decl_attributes): Look up existing declaration and
        pass it to decl_attributes.

gcc/c-family/ChangeLog:

        PR c/81544
        PR c/81566
        * c-attribs.c (attr_aligned_exclusions): New array.
        (attr_alloc_exclusions, attr_cold_hot_exclusions): Same.
        (attr_common_exclusions, attr_const_pure_exclusions): Same.
        (attr_gnu_inline_exclusions, attr_inline_exclusions): Same.
        (attr_noreturn_exclusions, attr_returns_twice_exclusions): Same.
        (attr_warn_unused_result_exclusions): Same.
        (handle_hot_attribute, handle_cold_attribute): Simplify.
        (handle_const_attribute): Warn on function returning void.
        (handle_pure_attribute): Same.
        (handle_aligned_attribute): Diagnose conflicting attribute
        specifications.
        * c-warn.c (diagnose_mismatched_attributes): Simplify.

gcc/cp/ChangeLog:

        PR c/81544
        * cp-tree.h (decls_match): Add default argument.
        * decl.c (decls_match): Avoid calling into the target back end
        and triggering an error.
        * decl2.c (cplus_decl_attributes): Look up existing declaration and
        pass it to decl_attributes.
        * tree.c (cxx_attribute_table): Initialize new member of struct
        attribute_spec.

gcc/fortran/ChangeLog:

        PR c/81544
        * f95-lang.c (gfc_attribute_table): Initialize new member of struct
        attribute_spec.

gcc/lto/ChangeLog:

        PR c/81544
        * lto-lang.c (lto_attribute_table): Initialize new member of struct
        attribute_spec.

gcc/ChangeLog:

        PR c/81544
        * attribs.c (empty_attribute_table): Initialize new member of
        struct attribute_spec.
        (decl_attributes): Add argument.  Handle mutually exclusive
        combinations of attributes.
        (selftests::test_attribute_exclusions): New function.
        (selftests::attribute_c_tests): Ditto.
        * attribs.h (decl_attributes): Add default argument.
        * selftest.h (attribute_c_tests): Declare.
        * selftest-run-tests.c (selftest::run_tests): Call attribute_c_tests.
        * tree-core.h (attribute_spec::exclusions, exclude): New type and
        member.
        * doc/extend.texi (Common Function Attributes): Update const and pure.

gcc/testsuite/ChangeLog:

        PR c/81544
        * c-c++-common/Wattributes-2.c: New test.
        * c-c++-common/Wattributes.c: New test.
        * c-c++-common/attributes-3.c: Adjust.
        * gcc.dg/Wattributes-6.c: New test.
        * gcc.dg/Wattributes-7.c: New test.
        * gcc.dg/attr-noinline.c
        * gcc.dg/pr44964.c: Same.
        * gcc.dg/torture/pr42363.c: Same.
        * gcc.dg/tree-ssa/ssa-ccp-2.c: Same.


Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/ada/ChangeLog
    trunk/gcc/ada/gcc-interface/utils.c
    trunk/gcc/attribs.c
    trunk/gcc/attribs.h
    trunk/gcc/brig/brig-lang.c
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-attribs.c
    trunk/gcc/c-family/c-warn.c
    trunk/gcc/c/ChangeLog
    trunk/gcc/c/c-decl.c
    trunk/gcc/config/alpha/alpha.c
    trunk/gcc/config/arc/arc.c
    trunk/gcc/config/arm/arm.c
    trunk/gcc/config/avr/avr.c
    trunk/gcc/config/bfin/bfin.c
    trunk/gcc/config/cr16/cr16.c
    trunk/gcc/config/epiphany/epiphany.c
    trunk/gcc/config/h8300/h8300.c
    trunk/gcc/config/i386/i386.c
    trunk/gcc/config/ia64/ia64.c
    trunk/gcc/config/m32c/m32c.c
    trunk/gcc/config/m32r/m32r.c
    trunk/gcc/config/m68k/m68k.c
    trunk/gcc/config/mcore/mcore.c
    trunk/gcc/config/microblaze/microblaze.c
    trunk/gcc/config/mips/mips.c
    trunk/gcc/config/msp430/msp430.c
    trunk/gcc/config/nds32/nds32.c
    trunk/gcc/config/nvptx/nvptx.c
    trunk/gcc/config/powerpcspe/powerpcspe.c
    trunk/gcc/config/rl78/rl78.c
    trunk/gcc/config/rs6000/rs6000.c
    trunk/gcc/config/rx/rx.c
    trunk/gcc/config/s390/s390.c
    trunk/gcc/config/sh/sh.c
    trunk/gcc/config/sparc/sparc.c
    trunk/gcc/config/spu/spu.c
    trunk/gcc/config/stormy16/stormy16.c
    trunk/gcc/config/v850/v850.c
    trunk/gcc/config/visium/visium.c
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/cp-tree.h
    trunk/gcc/cp/decl.c
    trunk/gcc/cp/decl2.c
    trunk/gcc/cp/tree.c
    trunk/gcc/doc/extend.texi
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/f95-lang.c
    trunk/gcc/lto/ChangeLog
    trunk/gcc/lto/lto-lang.c
    trunk/gcc/selftest-run-tests.c
    trunk/gcc/selftest.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/c-c++-common/attributes-3.c
    trunk/gcc/testsuite/gcc.dg/attr-noinline.c
    trunk/gcc/testsuite/gcc.dg/pr44964.c
    trunk/gcc/testsuite/gcc.dg/torture/pr42363.c
    trunk/gcc/testsuite/gcc.dg/tree-ssa/ssa-ccp-2.c
    trunk/gcc/tree-core.h
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/include/ext/mt_allocator.h