[Bug c++/70909] Libiberty Demangler segfaults (4)

[mark at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70909

--- Comment #9 from Mark Wielaard <mark at gcc dot gnu.org> ---
(In reply to Markus Trippelsdorf from comment #8)
> This is what it should look like: [...]

How did you demangle that input string?
With the proposed patch the mangled string is rejected by the libiberty
demangler.

I assume since you were able to demangle it is a valid input string, but that
the demangler creates a cyclic graph for it that then blows up the stack when
trying to print out.


A smaller, valid, reproducer would be nice to have. Clearly some of the inputs
that crash the demangler because it creates a cycle in the parse graph are
bogus and should be rejected.

It isn't immediately clear to me whether the bug is that a cyclic graph is
created for this input string, or that the bug is that such a cycle is printed
out naively.