[Bug libstdc++/67114] [MinGW64] build failure with POSIX threads enabled

[keith.marshall at mailinator dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67114

Keith Marshall <keith.marshall at mailinator dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |keith.marshall at mailinator dot c
                   |                            |om

--- Comment #21 from Keith Marshall <keith.marshall at mailinator dot com> ---
(In reply to ralphengels@gmail.com from comment #13)
> Also needs a small change in pthread.h to guard against including windows.h
> 
> #if defined(PTW32_CONFIG_MINGW) && defined(__cplusplus)
> 
> change to
> 
> #if defined(PTW32_CONFIG_MINGW) && defined(PTW32_BUILD) &&
> defined(__cplusplus)

Agreed, pthread.h from pthreads-win32 needs to change, (but that's hardly an
issue of particular interest here).  Personally, I would patch it much more
aggressively: it should NEVER include windows.h, but it also incorporates a
load of additional cruft which simply doesn't belong there.

However, this isn't the place to discuss such issues; let's take them up on a
MinGW.org, or a pthreads-win32, focussed mailing list.