[Bug libfortran/66936] io/unix.c gratuitously uses S_IRWXG and S_IRWXO on the basis that umask() is available

sgk at troutmask dot apl.washington.edu gcc-bugzilla@gcc.gnu.org
Thu Aug 6 18:11:00 GMT 2015


https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66936

--- Comment #12 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Thu, Aug 06, 2015 at 04:57:15PM +0000, fxcoudert at gcc dot gnu.org wrote:
> 
> Index: io/unix.c
> ===================================================================
> --- io/unix.c   (revision 226632)
> +++ io/unix.c   (working copy)
> @@ -1083,6 +1083,14 @@ set_close_on_exec (int fd __attribute__ 
>  }
> 
> 
> +/* On mingw, we don't use umask in the function below, because it
> +   doesn't support the user/group/other-based permissions.  */
> +
> +#ifdef __MINGW32__
> +#undef HAVE_UMASK
> +#endif
> +

Aren't there enough occurences of __MINGW32__ in io/unix.c?
Why add yet another kludge?  Put the #undef at line 48.



More information about the Gcc-bugs mailing list