[Bug c++/55189] enable -Wreturn-type by default

manu at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Thu Apr 17 13:13:00 GMT 2014


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55189

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #9 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Sylvestre Ledru from comment #8)
> The patches to fix this bug are available here:
> https://github.com/sylvestre/gcc
> I am doing the legal FSF papers to be able to apply it.

Cool! Hopefully it goes quickly. After that, I would suggest that you submit
the patch to gcc-patches and CC Jason Merrill and Dodji Seketeli, either of
them should be able to approve this.

I noticed that your patch does not update doc/invoke.texi to reflect the fact
that -Wreturn-type is enabled by default instead of by -Wall (it would be great
to automatically generate some parts of the manual from the options
description).

I also noticed that you did not include -Wmissing-return in your patch as
discussed here: http://gcc.gnu.org/ml/gcc/2013-11/msg00288.html

(Perhaps you did, and I am using github incorrectly?)

I think you will get easier approval if you include it (or send two patches in
the same email) and point out to the previous discussion (in particular Dodji,
Joseph and Jason's approval of this idea).


More information about the Gcc-bugs mailing list