[Bug c++/58362] Wrong column number for unused parameter

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58362

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |manu at gcc dot gnu.org

--- Comment #5 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Paolo Carlini from comment #4)
> The damage happens at error.c:3435. Should we just use "%qD", no '+' ?

Yes. And this is the reason I am against the magic +/# for location info.
Unless you know (and keep remembering) the diagnostic machinery very well, the
+ doesn't mean anything and it is easy to miss, whereas
"warning_at(DECL_SOURCE_LOCATION(decl)" seems pretty self-evident to me.