[Bug middle-end/56524] [4.8 Regression] Compiler ICE when compiling with -mips16

jakub at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Thu Mar 7 08:15:00 GMT 2013


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56524

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-03-07 08:14:17 UTC ---
I don't like the patch too much.  Why are you removing the cfun->optabs stuff?
set_cfun is called pretty often, e.g. during IPA switching to various functions
and back, when you remove cfun->optabs, it will constantly need to recompute
the optabs (quite expensive operation) if switching between mips16 vs.
non-mips16 functions with different optimization attributes.  The base_optabs
stuff is fine, but I'd just remove the ggc_free and in
invoke_set_current_function_hook
restore the saving of the computed optabs into cfun->optabs and using it if
already set.



More information about the Gcc-bugs mailing list