[Bug fortran/44978] derived types are resolved more than once

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44978

--- Comment #12 from Mikael Morin <mikael at gcc dot gnu.org> ---
Created attachment 30630
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=30630&action=edit
Janus' patch with void functions

(In reply to janus from comment #11)
> IMHO it is probably not worth the hassle. I wouldn't like to do this without
> having a concrete reason for it (and with a clean testsuite I don't see any).
> 
The reason is: 
the sym->resolved flag is an internal detail that should not be externally
visible; it shouldn't change the return value.

> 
> Well, the advantage of my original patch is obviously that it not only
> avoids the double errors, but it also prevents us from doing double the work
> in resolving the symbols, so it might even give a performance improvement
> for large codes, in particular with heavy OOP (not sure if it's anywhere
> close to being significant, though).

All right, the only one solution left that I see is the one making the
functions void. See the attached patch (comments welcome).
I ran the testsuite partially on it and it was clean, but I don't have the time
to finish that right now. It looked as slow as usual by the way. ;-)