[Bug c/52991] attribute packed broken on mingw32?

[rth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52991

Richard Henderson <rth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at gcc dot gnu.org

--- Comment #9 from Richard Henderson <rth at gcc dot gnu.org> 2012-12-18 17:14:37 UTC ---
It doesn't look to me that the first two hunks of the patch are needed.

The last hunk doesn't look like it should be considering either TYPE_PACKED
of the parent structure, or TYPE_ALIGN of the field type, but rather
using DECL_ALIGN of the field.  Which ought already have been assigned
by layout_decl via update_alignment_for_field.

The biggest problem to me appears to be the entire ms_bitfield_layout_p
block of code there, whose block comments talk about adjusting bitfields,
and yet is firing for structures that contain no bitfields at all.  That
tells me that the logic higher in the block (or elsewere wrt bitfield_layout_p)
is in error.