[Bug c++/53061] New: [C/ObjC/C++/ObjC++] cleanup diagnostics initialization

[manu at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53061

             Bug #: 53061
           Summary: [C/ObjC/C++/ObjC++] cleanup diagnostics initialization
    Classification: Unclassified
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: manu@gcc.gnu.org


Created attachment 27212
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=27212
patch

See http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00443.html and other emails in
that thread.

My latest patch is attached.

Changelog is:

2012-04-09  Manuel López-Ibáñez  <manu@gcc.gnu.org>

        * doc/invoke.texi (fmessage-length): Update.
        * pretty-print.h (getenv_columns): New.
        * c-objc-common.c (c_objc_common_init): Do not do diagnostics
        initialization here.
c-family/
        * c-opts.c (c_common_initialize_diagnostics): Rename as
        c_common_diagnostics_defaults. Set defaults here.
        * c-common.h (c_common_initialize_diagnostics): Likewise.
cp/
        * cp-objcp-common.c (cxx_initialize_diagnostics): Move from
        here to ...
        * error.c: ... here.
        (init_error): Delete.
        * cp-tree.h (init_error): Delete.
        * lex.c (cxx_init): Do not call init_error.
        * cxx-pretty-print.c (pp_cxx_pretty_printer_init): Do not set
        default message length here.


I prefer to focus on other things, so feel free to take it and do whatever you
need to get it approved.