[Bug c/7652] -Wswitch-break : Warn if a switch case falls through

[daniel.marjamaki at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=7652

Daniel Marjamäki <daniel.marjamaki at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.marjamaki at gmail
                   |                            |dot com

--- Comment #7 from Daniel Marjamäki <daniel.marjamaki at gmail dot com> 2011-07-29 13:28:41 UTC ---
In my experience this type of check is really noisy if there is a warning for
every fall through.

I recommend that the warning is written only if the fall through cause
redundant or bad behaviour. such as:

    switch (foo) {
    case 1: x = y;   // <- redundant assignment
    case 2: x = z;
    };

Or:

    switch (foo) {
    case 1: p = NULL;
    case 2: *p = 2;    // fall through => NULL pointer dereference
    };