[Bug other/46677] frontends and tree optimizers use *_TYPE_SIZE

amylaar at gcc dot gnu.org gcc-bugzilla@gcc.gnu.org
Mon Dec 13 19:17:00 GMT 2010


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46677

--- Comment #13 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2010-12-13 19:16:47 UTC ---
(In reply to comment #12)
> On Sat, 11 Dec 2010, amylaar at gcc dot gnu.org wrote:
> 
> > We don't have any current decimal floating or fixed-point type size macros
> > to replace.  As discussed elsewhere, the stdint type, wchar type, and ada long
> 
> Yes we do.  The definitions starting with DECIMAL32_TYPE_SIZE in 
> defaults.h.

Are these really supposed to be a target interface?  They are not documented,
nowhere overridden, and besides, it would appear odd to have a
DECIMAL32_TYPE_SIZE of, say, 31 bits.
It seems these macros just serve to make the code more readable.
Maybe they should be moved to tree.h ?

> 
> > DEFHOOK
> > (atomic_type,
> 
> The name should reflect that this is purely about sig_atomic_t and not 
> about any other form of atomicity - that is, sig_atomic_type or similar.

Point taken.  Using sig_atomic_type as the hook name makes sense.



More information about the Gcc-bugs mailing list