[Bug target/38781] PR38151: valgrind finds problem

dcb314 at hotmail dot com gcc-bugzilla@gcc.gnu.org
Thu Jan 15 21:51:00 GMT 2009



------- Comment #4 from dcb314 at hotmail dot com  2009-01-15 21:51 -------
(In reply to comment #3)
> An updated patch is at
> 
> http://gcc.gnu.org/ml/gcc-patches/2009-01/msg00747.html

I have a couple of minor questions about the coding style
of this patch.

1. Why is the "/ 8 / 8" a good idea ? 

Presumably "/ 64" doesn't do it right ?

2. On the middle condition of the for-loop, could it
be micro-optimised to compute the upper limit of the
for loop before the loop starts ?

For example, instead of

; (i < A) && (i + pos) < B; ++i

replace with 

const int limit = min( A, B - pos);

...

; i < limit; ++i


Just an idea.


-- 

dcb314 at hotmail dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38781



More information about the Gcc-bugs mailing list