[Bug testsuite/25352] xfail within dg-do command has no effect

[janis at gcc dot gnu dot org]

------- Comment #8 from janis at gcc dot gnu dot org  2007-05-11 00:51 -------
I had forgotten all about this.  Today I checked to see how older versions of
DejaGnu and GCC tests handled xfail for dg-do keywords other than "run".  I
only went back as far as GCC 3.0.4 and DejaGnu 1.4, but they also ignored xfail
in dg-do for preprocess/compile/assemble/link.

There are currently 27 tests that use this construct: three in libstdc++-v3 and
24 in gcc.

My recommendations are to document, in the description of test directives in
the GCC Internals manual, that xfail for dg-do is only honored for dg-do run
and ignored for other keywords, recommending the use of dg-xfail-if instead;
and to remove the xfail section from the 27 tests that use it when it's
ignored.

I'll do these if it sounds reasonable.  I don't think this is worth working
around in the GCC testsuite support or fixing in DejaGnu.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25352