[Bug middle-end/23125] [4.0/4.1 Regression] OpenBSD's zic.c causes g++ but not gcc to segfault

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-09-10 04:56 -------
This was introduced by:
2004-08-04  Geoffrey Keating  <geoffk@apple.com>

        PR 14516
        * c-common.c (c_expand_decl): Don't special-case static VAR_DECLs.
        * c-common.h (make_rtl_for_local_static): Delete.
        * c-decl.c (shadow_tag_warned): Clean up comment.
        (finish_decl): Clean up spacing.  Use set_user_assembler_name when
        appropriate.  Don't pass asmspec to rest_of_decl_compilation.
        * c-semantics.c (make_rtl_for_local_static): Delete.
        * expr.c (init_block_move_fn): Use set_user_assembler_name.
        (init_block_clear_fn): Likewise.
        * passes.c (rest_of_decl_compilation): Remove asmspec parameter,
        expect it to be in DECL_ASSEMBLER_NAME.  Update callers in many files.
        * toplev.h (rest_of_decl_compilation): Remove asmspec parameter.
        * tree.h (make_decl_rtl): Remove second parameter.
        (set_user_assembler_name): New.
        * varasm.c (set_user_assembler_name): New.
        (make_decl_rtl): Remove second parameter.  Update callers in many
        files.

So it is little harder to fix than I had previous thought as there is no way to know if user set the decl 
name or if it was just the name of the decl.   The front-ends have to be fixed to call 
set_user_assembler_name all the time and then make_decl_rtl needs to be updated for that but I don't 
have the time to test that patch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |geoffk at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23125