test failures due to quote marks

Joseph S. Myers jsm@polyomino.org.uk
Fri Oct 22 18:48:00 GMT 2004


On Fri, 22 Oct 2004, Nathan Sidwell wrote:

> Today I had a load of test failures, which AFAICT stem from the
> diagnostics being emitted with 0x321 & 0x322 quote marks rather than
> regular ` and ' marks.  I don't think I've changed anything in my
> environment -- it's building  a pristine tree in the same shell that worked
> yesterday.

The patch to define HAVE_LANGINFO_CODESET went in, so now UTF-8 LC_CTYPE 
gets proper quotes in English messages.

If the testsuite doesn't run with LC_ALL=C, something must be broken - I'd 
just presumed that any testsuite harness testing diagnostics would have 
set LC_ALL=C for years to avoid failing when translations are used.  But 
absent that, LC_ALL=C should be set for make check.

The easiest place to set LC_ALL for running the testsuite is probably in 
gcc/Makefile.in where other environment variables are set for the 
testsuite, though there may be a "right" place in the dejagnu files 
somewhere.

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)



More information about the Gcc-bugs mailing list