[Bug bootstrap/14893] [3.5 Regression] 3.4.0-20040406, 'make install' fails on doc/gcjh.1

aoliva at gcc dot gnu dot org gcc-bugzilla@gcc.gnu.org
Thu Apr 15 07:03:00 GMT 2004


------- Additional Comments From aoliva at gcc dot gnu dot org  2004-04-15 05:10 -------
Yeah, this is ok for mainline.

Putting on my paranoid Makefile writer hat, I'd recommend adding an `else :'
between if/fi, just because some shells carry over the exit status of the if
test command to the whole if command, and, if that turns out to be a failure and
we're in `set -e' mode, which Makefile generally enbles, the whole thing falls
apart.  I don't quite recall whether shells with this behavior are common, but I
do remember they exist (I'd guess Ultrix if I had to).  I'm not sure we care
about it at this point, but there are several such constructs in the gcc
Makefiles, so perhaps we should stick to it.

Sorry that I forgot about it in my previous posting.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=14893



More information about the Gcc-bugs mailing list