gcc 3.4 make install problem

[Christian Cornelssen]

Hi,

On Tue, 28 Jan 2003, DJ Delorie wrote:

> > JFTR, the "old fashioned way" stopped working with gcc 3.4 about
> > ~2-3 weeks ago.
>
> Could you narrow down the specific patch that broke it?  That would be
> helpful (esp since I tried your build on my machine, and it worked).

That's my patch:

2003-01-09  Christian Cornelssen  <ccorn@cs.tu-berlin.de>

        * Makefile.in (install_to_libdir, install_to_tooldir): Add a
        mkinstalldirs command.

However, this just _uses_ the already existent definition of
mkinstalldirs.  The error would also have shown up without my
patch if Urs had a non-empty ${target_header_dir}.

Let me summarize what I see: Libiberty is built two times, once for
bootstrapping the compiler and once more with the run-time libs.
The former happens outside the library-building subdir
(i686-pc-linux-gnu/ in this case), the latter is done inside.
In Urs's system, both cases use srcdir=., thus breaking the reference
to mkinstalldirs in the latter case.  Fixing is not straightforward:
If you fix the subdir case, bootstrapping the compiler will fail.
But a look at `libiberty/configure.in' suggests the following patch:

--- libiberty/Makefile.in	28 Jan 2003 21:53:49 -0000	1.78.2.3
+++ libiberty/Makefile.in	29 Jan 2003 02:54:47 -0000
@@ -50,7 +50,7 @@
 INSTALL = @INSTALL@
 INSTALL_PROGRAM = @INSTALL_PROGRAM@
 INSTALL_DATA = @INSTALL_DATA@
-mkinstalldirs = $(SHELL) $(srcdir)/../mkinstalldirs
+mkinstalldirs = $(SHELL) $(libiberty_topdir)/mkinstalldirs

 # Some compilers can't handle cc -c blah.c -o foo/blah.o.
 OUTPUT_OPTION = @OUTPUT_OPTION@

Urs, could you try this (building in place this time)?
The patch would be applicable to 3.3 as well.  If you succeed
with 3.4, also trying 3.3 first without and then with the patch would
be nice.

If this works, probably the TEXISRC definition and more places
in `libiberty/Makefile.in' will need to be updated similarly...

Regards,

Christian Cornelssen