java/5688: cross compiler build fails in libjava

Alexandre Oliva aoliva@redhat.com
Tue Jun 4 13:41:00 GMT 2002


On Jun  4, 2002, "H . J . Lu" <hjl@lucon.org> wrote:

> +     case $target in

As I wrote before, $target is meaningless in target libraries.  Please
make this $host and check it in.

> +   if test x$build = x$host; then

If you have a spare second, please enclose x$build and x$host in
quotes, just because I'm paranoid :-)

Quotes are not necessary for safety in the `case' case :-), because
`case' expands its argument into a single word, but for test there's
no such special handling in the shell, so I often like to take the
safe route.

-- 
Alexandre Oliva   Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer                  aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp        oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist                Professional serial bug killer



More information about the Gcc-bugs mailing list