[SB #944] bug in mips32 gcc-3.0.1 doing copy_to_user in 2.4.17 linux affects ip_tables-1.2.5 firewall code update

[DJ Barrow]

I did some more tests with ip_tables & it still crashed when 
using other options with the fix I previously posted.

The bug I suspect doesn't happen in the 2.4.18 distro from
kernel.org as its uaccess.h is less aggressive.

gcc is buggy & the broadcom distro of uaccess.h register 
usage macros highlight this bug.
Basically gcc has a bad hair day when you try to force
specific registers for parameters on assembly inlines if
under pressure & in danger of register spillage.
We had these problems in the s390 port also in uaccess macros.

I merged the uaccess.h of the generic 2.4.18 
from kernel.org which doesn't do this
with the uaccess.h from a 2.4.17 from broadcom
& kept broadcom's fixes.

I suggest you broadcom guys use it in your next distro.

In short all you need is the uaccess.h patch below & the
the iptables problems appear to be fixed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uaccess.patch
Type: text/x-diff
Size: 5402 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-bugs/attachments/20020424/b8a02731/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: uaccess.h
Type: text/x-c
Size: 13009 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-bugs/attachments/20020424/b8a02731/attachment-0001.bin>