SH-ELF: shift_cost[] indexed incorrectly and RTX_COST problems

tm tm@kloo.net
Thu Sep 20 22:59:00 GMT 2001


Joern Rennecke wrote:
> 
> I have checked the appended patch into the 3.0 branch and the mainline.
> This fixes the out-of-bounds array indexing of shift_cost and the costs
> for shift.
> I don't see any compelling reason to fix all the costs for DImode
> operations, since it seems to work fairly good anyways, and we never
> made any real effort to get good code for long long anyways.
> 
> If you can show me a testcase that really benefits from more accurate
> costs, I might reconsider.
> 
> Thu Sep 20 12:49:34 2001  J"orn Rennecke <amylaar@redhat.com>
> 
>         * sh.c (shiftcosts): Don't use shiftcosts array for modes wider
>         than SImode.
> 

This seems okay for now.

Thank you for the patch.

Toshi



More information about the Gcc-bugs mailing list